I suggest we create a new function called fillpdf_fields_create_update() which can both edit and create entries in the fillpdf_fields table. This function would replace fillpdf_update_field().

CommentFileSizeAuthor
#5 fillpdf-fillpdf_fields_create_update-2332323-5.patch4.72 KBLiam Morland
#1 fillpdf-fillpdf_fields_create_update-2332323-1.patch3.62 KBLiam Morland
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Status: Active » Needs review
FileSize
fillpdf-fillpdf_fields_create_update-2332323-1.patch3.62 KB

I am interested in your feedback on this before I commit.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions as a volunteer commented
Status: Needs review » Needs work
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions as a volunteer commented

Oops. I somehow deleted my comment from before: basically, you should move the old function into fillpdf.deprecated.inc and make it call the new function with the right signature. We didn't mark it as internal (beginning with an underscore), so we shouldn't just remove it unless we're going to cut 7.x-3.x.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Needs work » Needs review
FileSize
fillpdf-fillpdf_fields_create_update-2332323-5.patch4.72 KB

Status: Needs review » Needs work

The last submitted patch, 5: fillpdf-fillpdf_fields_create_update-2332323-5.patch, failed testing.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Needs work » Needs review
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions as a volunteer commented
Status: Needs review » Reviewed & tested by the community

+1, let's put it into the RC

  • Liam Morland committed eedebb3 on 7.x-1.x 
    Issue #2332323: API change: Create fillpdf_fields_create_update() to...
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.