There is a list of the latest quizzes at the end of the question creation/editing page. Currently the list grows indefinitely, which pushes the Save button very far and also causes the page to load very slowly.

The UI has gotten a complete overhaul in 7.x-5.x, so this issue doesn't exist there anymore.

CommentFileSizeAuthor
#1 quiz-latest_quizzes_grows_indefinitely-2331227-1.patch1.14 KBjuho-jaakkola
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juho-jaakkola’s picture

juho-jaakkola CreditAttribution: juho-jaakkola commented
FileSize
quiz-latest_quizzes_grows_indefinitely-2331227-1.patch1.14 KB
dandaman’s picture

dandaman CreditAttribution: dandaman commented
Assigned: juho-jaakkola » Unassigned
Status: Active » Reviewed & tested by the community

Very helpful for 4.x users!

On a site I run there's tons of quizzes, and the fact that it loads every quiz that matches if they've never worked on a quiz before makes the page take a LONG time to load.

Thanks for the patch!

Ohh, one thing. Your patch has this:

$sql .= " ORDER BY changed LIMIT {$limit}";

I don't think those brackets are doing anything and should only be used around tables, so I just took them off and it did the same thing (might screw up some people who have a table prefix too):

$sql .= " ORDER BY changed LIMIT $limit";
dandaman’s picture

dandaman CreditAttribution: dandaman commented
Status: Reviewed & tested by the community » Needs work

Well, would be RTBC if the code issue above is fixed.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Fixed

The curly braces evaluate the variable since the string is in double quotes, so no issues here.

I committed this to 4.x

Not required in 5.x because we removed the recent Quiz list in favor of Entity API/Views.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.