Syntax Highlighter for cgit.drupal.org cant handle embedded binaries in features [#2331007]

http://cgit.drupalcode.org/sandbox-rvilar-1313302/ tree/modules/features/openplaza_default_content/openplaza_default_content.features.content.inc

Apparently features thinks(thought?) its a fine idea to go ahead and embed binary data into php include files to deploy content.

The python syntax highlighter doesnt know how to handle this, so it just heats up the CPUS on util to 99%.

Not sure if we should
A. look for binary data in .inc files and not syntax highlight,
B. not host .inc files with embedded binary data?
C. setup a sheriff script that terminates syntax highlighters that have been misbehaving?

Comments

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 1 September 2014 at 22:41

I'd recommend C, that's what I've been effectively doing. (B wouldn't work since we can't rewrite this sort of thing out of the history of all Git repos we host.)

I'd consider this to be a bug in Pygments, maybe https://bitbucket.org/birkenfeld/pygments-main/issue/946/pygments-hangs-... would resolve it.

Comment #2

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 2 September 2014 at 18:00

Issue summary:

View changes

Breaking the link

Comment #3

drumm

he/him

NY, US

CreditAttribution: drumm commented 12 September 2014 at 00:54

Processes to kill:

$ sudo ps -F --pid "$(sudo pgrep -d, -u apache python2)"

Problems with this:

It should only select processes that have been running for a long time, maybe any over 5 seconds.
If there is nothing matching pgrep, then ps is not happy.

When that's all good, we can go ahead and set up the command to kill those processes.