Language condition plugin needs LanguageManager injected, unit tests added [#2328463]

Problem/Motivation

Drupal\language\Plugin\Condition\Language does not take the language manager injected and is not unit tested.

Proposed resolution

Inject language manager, unit test.

Remaining tasks

All of them.

User interface changes

None.

API changes

Likely none.

Comment	File	Size	Author
#2	2328463-languagemanager_injected-2.patch	839 bytes	janoka
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

janoka CreditAttribution: janoka commented 12 September 2014 at 07:23

Assigned:

Unassigned

» janoka

I'll check it.

Comment #2

janoka CreditAttribution: janoka commented 18 September 2014 at 20:49

Status:

Active

» Needs review

File	Size
2328463-languagemanager_injected-2.patch	839 bytes

Please check my code. Do you think that solution? If yes, then I will write the unit test.

Comment #3

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 19 September 2014 at 07:11

Status:

Needs review

» Needs work

Certainly better than using language_list() :) Actually injecting the language manager would mean you pass on an instance of $language_manager as a property to either the constructor or create method or a specific setter method that is used to set dependent services on conditions. See https://www.drupal.org/node/2133171 for explanation on various ways of of injection and check what conditions use elsewhere. (They may not support injection yet but hopefully they do :)