Fix views support for DivIcon (HTML) markers

milesw, it seems the path is not against the latest dev version. Here's correct one.

Works fine for me, against current 7.x-1.x-dev.

Thanks for fixing patch path in #8, milesw. Works fine as well.

It appears the we should set iconSize for views as well, otherwise leaflet sets default icon size.

I've still trouble with the patches posted here.
Here's a manual re-roll - no clue if the functionality is as intended.
However I start to test the functionality now.

Just stumbled over notices triggered by the current patch.
The icon size handling should work for html and marker - but currently it deals with a variable that's just available if a marker is configured.
Added condition.

das-peter's patch applied OK and provides html output as a leaflet point marker for me. Click event still works to boot :)
I read above about "latest dev" of d.o leaflet module, but that one threw an error for me here:
http://cgit.drupalcode.org/leaflet/commit/?id=d3843bd
Instead, I reverted just the line at the bottom:

-      // Use a Zoomswitch Layer extension to enable zoom-switch option.
-      var map_layer = new L.TileLayerZoomSwitch(layer.urlTemplate);
+      var map_layer = new L.TileLayer(layer.urlTemplate);

and that allowed the plugin as well as the html point style to work.

Folks - I would love to review this and add my support to a RTBC status, but I lack the knowledge of how to use the *@%$#!! DivIcon functionaltiy! If someone on this thread could be so kind as to show some views field config that makes this work, it would not only help me heaps (cause I need this), but as mentioned I will add my $0.02 to the review.

Thanks!

@milesw - I should have been more clear. I get all of that, it's the actual field HTML that I don't get -- my CSS sucks if that helps you see where I'm coming

@milesw - of course I need this feature, that's why I'm here... but my inexperience with CSS is causing me to fail to check this out. I also understand the field HTML gets rendered, but to construct field HTML that creates a usable custom icon escapes me.

I was able to get going on this -- thanks to those who offered guidance. This patch works as advertised. I also added a related issue, which I created to provide documentation on some use cases for this feature at https://www.drupal.org/node/2390627

In reference to @milesw step-by-step in #15.

5. For "Marker field" choose the Views field you want to output as your markers.

If you are wondering what to use for a basic Marker field, do the following.

In Fields, add a Global: custom text field and set its Text to  . You can leave the other settings to default in the Format | Settings UI. When you're done, Leaflet's default blue marker icons will be replaced by small white squares.

You can see this and more sophisticated options by visiting the page created by @robertwb here.

Patch in #12 worked for me.

Working for me too.

Patch #12 works in my Drupal setup, too. When in Leaflet module?

Marking this RTBC - patch applies against the most recent dev version (albeit with an offset).

Patch applied (manually as I've applied so many patches in the last couple of days, the code has changed -- please test 7.x-1.x-dev before we make it an official release!).
Rik

I will begin testing tomorrow - thanks @RdeBoer!

The latest dev version provides this functionality cleanly. Verified over the course of several days now and just moved into production systems. I move to mark this closed.

Great!
Thanks for confirming Robert.
Looks like we're almost read to make the current 7.x-1.x-dev the next official release.
I'll give it a little longer because so many patches have been applied recently.
Rik

Sounds good @RdeBoer - I guess it's pretty hard to develop automated testing for mapping/visualization stuff? Talk about an industry need...