Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
function _profiler_builder_export_variables() cannot handle deeply nested variables
Comment | File | Size | Author |
---|---|---|---|
#3 | deeply_nested_variables-2326889-3.patch | 3.96 KB | marbard |
#1 | deeply_nested_variables-2326889-1.patch | 3.91 KB | marbard |
Comments
Comment #1
marbard CreditAttribution: marbard commentedImplemented a patch which goes through variables recursively
Comment #2
btopro CreditAttribution: btopro commentedFINALLY someone tackling this (thank you). :) My previous solution was from like 3 years ago and was horrible. Can we get some additional testing on this?
One thing to note in the patch; can you change the function name from _flatten_array to _profiler_builder _flatten_array. I'm a stickler for namespacing on all helper functions.
Comment #3
marbard CreditAttribution: marbard commentedI've renamed the function as you've requested.
We've used this patch in my workplace, seems to work fine. Though additional testing wouldn't hurt I suppose :-)
Comment #4
btopro CreditAttribution: btopro commentedexcellent! tested on simplytest.me and it looked good Thanks for another great patch