Move classes out of the preprocess functions and into the Twig templates. Make sure all classes get into the resultant markup, even ones inherited.

Preprocess Functions Modified

core/includes/menu.inc: template_preprocess_menu_tree
core/themes/bartik/bartik.theme: bartik_preprocess_menu_tree

Twig Templates Modified

core/modules/system/templates/menu-tree.html.twig

Files: 
CommentFileSizeAuthor
#6 move_menu_classes_from-2324661-6.patch2.62 KBlauriii
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 76,102 pass(es). View

Comments

pwolanin’s picture

Assigned: Unassigned » pwolanin

I'll take a shot at this today

dawehner’s picture

pwolanin’s picture

@dawehner, well this is about re-arranging the classes only

Cottser’s picture

Title: Consensus Banana Phase 1, Move menu classes from preprocess to template » Move menu classes from preprocess to template
Cottser’s picture

Title: Move menu classes from preprocess to template » Move menu classes from preprocess to templates
lauriii’s picture

Status: Active » Needs review
FileSize
2.62 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 76,102 pass(es). View
Wim Leers’s picture

dawehner’s picture

Status: Needs review » Postponed

so

davidhernandez’s picture

davidhernandez’s picture

Status: Postponed » Needs work

I'm assuming at least a reroll?

davidhernandez’s picture

Assigned: pwolanin » Unassigned
lanchez’s picture

Assigned: Unassigned » lanchez
lanchez’s picture

Assigned: lanchez » Unassigned

This does not seem to be a relevant issue anymore.

lauriii’s picture

Status: Needs work » Closed (won't fix)

There's no more template_preprocess_menu_tree