script.js in kit subtheme overrides oa radix script.js because they have the same name [#2323685]

When you create a sub theme using the kit thereare problems with the positioning of the panels in place editor (IPE) and the nav menu collapse.

This is because the script.js in the kit theme overrides the script.js in the oa_radix theme (and is empty).

If there are scripts in the oa_radix theme that need to be inherited they need to be in a file with a different name.
Otherwise the scrips need to be added to the kit subtheme.

Comment	File	Size	Author
#7	oa_radix-rename-script.js-to-scripts.js-2323685-7.patch	642 bytes	candelas
#4	oa_radix-update-_variable.scss-to-bootstrap-sass-3.0.3.0-2408279-4.patch	66.25 KB	candelas
#3	oa_radix-rename-script.js-to-scripts.js-2323685-3.patch	229 bytes	candelas

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rooby CreditAttribution: rooby commented 19 August 2014 at 02:29

Related issues:

+#2170593: Default sub-theme is broken

This was originally reported in #2170593: Default sub-theme is broken

Comment #2

candelas CreditAttribution: candelas commented 22 January 2015 at 23:46

This is very important. It took to me hours to find out way the navbar was not working.

Comment #3

candelas CreditAttribution: candelas commented 5 February 2015 at 05:56

Status:

Active

» Needs review

File	Size
oa_radix-rename-script.js-to-scripts.js-2323685-3.patch	229 bytes

I made a very small patch to rename kits/default/assets/javascripts/script.js to kits/default/assets/javascripts/scripts.js

Comment #4

candelas CreditAttribution: candelas commented 5 February 2015 at 07:10

File	Size
oa_radix-update-_variable.scss-to-bootstrap-sass-3.0.3.0-2408279-4.patch	66.25 KB

1 file was hidden/shown/deleted

File	Size
oa_radix-rename-script.js-to-scripts.js-2323685-3.patch	229 bytes

I made a mistake and put a blank file. Here it is the right one

Comment #5

candelas CreditAttribution: candelas commented 5 February 2015 at 07:16

2 files were hidden/shown/deleted

File	Size
oa_radix-rename-script.js-to-scripts.js-2323685-3.patch	229 bytes
oa_radix-update-_variable.scss-to-bootstrap-sass-3.0.3.0-2408279-4.patch	66.25 KB

Sorry, I mistake issue. I hope I get used to the system and not to do so many mistakes :)

Comment #6

candelas CreditAttribution: candelas commented 5 February 2015 at 07:20

Title:

Javascript in oa_radix not present in kit subtheme

» script.js in kit subtheme overrides oa radix script.js because they have the same name

Trying to make the title more specific.

Comment #7

candelas CreditAttribution: candelas commented 5 February 2015 at 08:38

File	Size
oa_radix-rename-script.js-to-scripts.js-2323685-7.patch	642 bytes

1 file was hidden/shown/deleted

File	Size
oa_radix-rename-script.js-to-scripts.js-2323685-3.patch	229 bytes

I realized that I had to change also the name in /kits/default/default.info

Comment #8

candelas CreditAttribution: candelas commented 12 February 2015 at 10:53

Priority:

Normal

» Major

I classify as major, since if you make a subtheme the oa_radix scripts will not work. If I am wrong, please correct to me :)

Comment #9

hosais CreditAttribution: hosais as a volunteer commented 15 July 2015 at 18:41

@candelas

After updating, I noticed the problem that "the navbar was not working" like you.
Do you remember to enable bootstrap functinoality? (admin/config/development/bootstrap_library, Visibility -> Activate on specific themes -> Only the listed themes, add yourtheme). I forget this many times and spent hours to realize it.