Error in Views Filter Nodes based on Current user that have term reference same in nodes.

It would be kind of cool if you could provide an export of that view. This seems to be no straightforward view to rebuild.

Well, please enable error display under "logging and errors" under admin/config

I was able to reproduce this by adding a content view with a relationship using field_tags and then tried to add a vocabulary filter. I can't edit my view anymore.

Error
The website has encountered an error. Please try again later.
Error message

Notice: Trying to get property of non-object in Drupal\views\Plugin\views\HandlerBase->getEntityType() (line 760 of core/modules/views/src/Plugin/views/HandlerBase.php).

    Drupal\views\Plugin\views\HandlerBase->getEntityType()
    Drupal\views\Plugin\views\filter\Bundle->init(Object, Object, Array)
    Drupal\views\Plugin\views\display\DisplayPluginBase->getHandlers('filter')
    Drupal\views\Plugin\views\display\DisplayPluginBase->getHandler('filter', 'vid_1')
    Drupal\views_ui\Form\Ajax\ConfigHandler->buildForm(Array, Object)
    call_user_func_array(Array, Array)
    Drupal\Core\Form\FormBuilder->retrieveForm('views_ui_config_item_form', Object)
    Drupal\Core\Form\FormBuilder->buildForm('Drupal\views_ui\Form\Ajax\ConfigHandler', Object)
    views_ajax_form_wrapper('Drupal\views_ui\Form\Ajax\ConfigHandler', Object)
    Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm(Object, 'default', 'nojs')
    Drupal\views_ui\Form\Ajax\ConfigHandler->getForm(Object, 'default', 'nojs', 'filter', 'vid_1')
    call_user_func_array(Array, Array)
    Drupal\Core\Controller\HtmlPageController->getContentResult(Object, '\Drupal\views_ui\Form\Ajax\ConfigHandler::getForm')
    Drupal\Core\Controller\HtmlPageController->content(Object, '\Drupal\views_ui\Form\Ajax\ConfigHandler::getForm')
    call_user_func_array(Array, Array)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
    Drupal\Core\DrupalKernel->handle(Object)

Exception: No entity type for field vid on view bundletest in Drupal\views\Plugin\views\HandlerBase->getEntityType() (line 770 of core/modules/views/src/Plugin/views/HandlerBase.php).

    Drupal\views\Plugin\views\HandlerBase->getEntityType()
    Drupal\views\Plugin\views\filter\Bundle->init(Drupal\views\ViewExecutable, Drupal\views\Plugin\views\display\DefaultDisplay, [Array])
    Drupal\views\Plugin\views\display\DisplayPluginBase->getHandlers(filter)
    Drupal\views\Plugin\views\display\DisplayPluginBase->getHandler(filter, vid_1)
    Drupal\views_ui\Form\Ajax\ConfigHandler->buildForm([Array], Drupal\Core\Form\FormState)
    call_user_func_array([Array], [Array])
    Drupal\Core\Form\FormBuilder->retrieveForm(views_ui_config_item_form, Drupal\Core\Form\FormState)
    Drupal\Core\Form\FormBuilder->buildForm(Drupal\views_ui\Form\Ajax\ConfigHandler, Drupal\Core\Form\FormState)
    views_ajax_form_wrapper(Drupal\views_ui\Form\Ajax\ConfigHandler, Drupal\Core\Form\FormState)
    Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm(Drupal\views_ui\ViewUI, default, nojs)
    Drupal\views_ui\Form\Ajax\ConfigHandler->getForm(Drupal\views_ui\ViewUI, default, nojs, filter, vid_1)
    call_user_func_array([Array], [Array])
    Drupal\Core\Controller\HtmlPageController->getContentResult(Symfony\Component\HttpFoundation\Request, \Drupal\views_ui\Form\Ajax\ConfigHandler::getForm)
    Drupal\Core\Controller\HtmlPageController->content(Symfony\Component\HttpFoundation\Request, \Drupal\views_ui\Form\Ajax\ConfigHandler::getForm)
    call_user_func_array([Array], [Array])
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Symfony\Component\HttpFoundation\Request, 1)
    Symfony\Component\HttpKernel\HttpKernel->handle(Symfony\Component\HttpFoundation\Request, 1, TRUE)
    Drupal\Core\DrupalKernel->handle(Symfony\Component\HttpFoundation\Request)

Here's a patch that uses this->table instead of this->view->relationships which are not available.

Added steps to reproduce to issue summary.

Yes. This fixes the issue and applies cleanly. I can edit a View with a broken handler now!

Are we really sure this is the proper fix? $this->table could point to something like node_field_data, which might or might not have 'entity type' on there.
Using the base tables (which is what the previous code did, feels much more secure.

Afaik we could also fix this issue by using $this->view->relationship[$relationship_name]->table instead.

Setting back to "needs review" to get answers to #11

#11: Good points.

Are we really sure this is the proper fix? $this->table could point to something like node_field_data, which might or might not have 'entity type' on there.
Using the base tables (which is what the previous code did, feels much more secure.

Isn't it the same problem with base tables?

Afaik we could also fix this issue by using $this->view->relationship[$relationship_name]->table instead.

That was my first thought but this method is invoked from an init() and having relationship[X]->table ready sounded like the init() of that relationship should be called before this one so went with something simple.

The same problems with related issue - I need to find the relation that used for the handler so

+++ b/core/modules/views/src/Plugin/views/HandlerBase.php
@@ -700,10 +700,8 @@ public static function getTableJoin($table, $base_table) {
+    if ($this->table !== NULL) {

This does not work for related, it returns "comment_entity_statistics" but I need to know the entity type of the relation

Suppose the proper fix as said #13

Maybe this?

Plain re roll of this, fixes the problem described with the relationships and filters.

Nice work!

Committed f51b029 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.