The following two lines aren't needed in the make file as these are the default values.

libraries[flexslider][directory_name] = "flexslider"
libraries[flexslider][type] = "library"

Drush Make will know that it's a library because of "libraries", and the next part ("flexslider") determines the name of the directory that it's put into. There's no advantage to defining these again, so these lines might as well be removed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

opdavies’s picture

Title: Extra lines in the make file » Remove extra lines from the make file
opdavies’s picture

Status: Active » Needs review
FileSize
745 bytes
opdavies’s picture

Also, why have this as .example?

Status: Needs review » Needs work

The last submitted patch, 2: flexslider-remove_extra_lines_from_make_file-2322199-1.patch, failed testing.

opdavies’s picture

FileSize
421 bytes

Patch in #2 re-rolled against a fresh version of 7.x-2.x.

opdavies’s picture

Status: Needs work » Needs review
minorOffense’s picture

The .example is considered best practice for Drupal contrib modules so to not create dependency loops in other make files.

I'll remove the "library" line but I want to force the name of the library folder in case woothemes changes the exported file name.

minorOffense’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.