The following two lines aren't needed in the make file as these are the default values.

libraries[flexslider][directory_name] = "flexslider"
libraries[flexslider][type] = "library"

Drush Make will know that it's a library because of "libraries", and the next part ("flexslider") determines the name of the directory that it's put into. There's no advantage to defining these again, so these lines might as well be removed.

Files: 
CommentFileSizeAuthor
#5 2322199-5.patch421 bytesopdavies
Test request sent.
[ View ]

Comments

opdavies’s picture

Title:Extra lines in the make file» Remove extra lines from the make file
opdavies’s picture

Status:Active» Needs review
StatusFileSize
new745 bytes
FAILED: [[SimpleTest]]: [MySQL] 100 pass(es), 44 fail(s), and 0 exception(s).
[ View ]
opdavies’s picture

Also, why have this as .example?

Status:Needs review» Needs work

The last submitted patch, 2: flexslider-remove_extra_lines_from_make_file-2322199-1.patch, failed testing.

opdavies’s picture

StatusFileSize
new421 bytes
Test request sent.
[ View ]

Patch in #2 re-rolled against a fresh version of 7.x-2.x.

opdavies’s picture

Status:Needs work» Needs review