When running Drupal on HHVM, and having the ldap_servers module enabled, the following warning appears:

Warning: Case insensitive constant names are not supported in HipHop in include() (line 35 of /srv/www/intranet/frontend/sites/all/modules/ldap/ldap_servers/ldap_servers.module).

The line in question contains the following:

define('LDAP_SERVERS_CYPHER_MODE', 'cfb', 12);

This looks like the third parameter is unintentional, since it's supposed to be a boolean, that if true, sets the constant to be case insensitive, which is not supported in HHVM. Since all usage of the constant is all-uppercase, there is no need for it to be case sensitive.

The attached patch removes the third argument, causing HHVM to stop complaining, and, in my testing, has no adverse effects.

CommentFileSizeAuthor
2014-08-14-ldap-avoid-case-insensitive-constant.patch1.07 KBmikl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikl’s picture

mikl CreditAttribution: mikl commented
Status: Active » Needs review
KeepXtreme’s picture

KeepXtreme CreditAttribution: KeepXtreme commented

*push*

please include this patch (if there are no compatibility issues) in the next release as this is heavily flooding the drupal logs

DeFr’s picture

DeFr CreditAttribution: DeFr at Axess Open Web Services commented
Status: Needs review » Reviewed & tested by the community

  • dgtlmoon committed 68fad64 on 7.x-2.x authored by mikl 
    Issue #2321295 by mikl: [PATCH] Avoid case-insensitive constant names
dgtlmoon’s picture

dgtlmoon CreditAttribution: dgtlmoon commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed, yeah that does seem very odd

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.