Problem / Motivation

In trying to test the changes documented in [#2170437], the simple registration of a config.module.overrides event seems to have no effect. The getSubscribedEvents() method fires, but the registered method is never called.

The test code is here: https://github.com/agentrickard/domain/tree/8.0.x/domain_config and contains simpletests.

There are, granted, a lot of moving parts here, so it may be a case of connecting all the dots.

It is not clear, for instance, if contrib modules need to create a Configuration Storage Collection [#2268523], or if overrides need to be enabled [#2182813].

But the current tests for this behavior in core are only unit tests, so far as I can tell, so we have no proper integration tests for the config override system. In contrib, they simply seem to fail.

Comments

agentrickard’s picture

Issue summary: View changes
beejeebus’s picture

it looks like [#2170437] is way out of date.

i poked around looking for 'config.module.overrides', and i think they have been refactorised out of existence.

i tried to make sense of the existing code for a few minutes, but gave up - it's way over my head.

agentrickard’s picture

That at least makes me feel better.

agentrickard’s picture

Title: Config override events do not fire » Document Config Module Overrides
Category: Bug report » Task
Issue tags: +Config documentation

OK. I got things working today. The EventSubscriber has been deprecated in favor of ConfigFactoryOverrideInterface.

The documentation all needs to be rewritten.

jhedstrom’s picture

Status: Active » Needs review

I updated the config override documentation page to account for ConfigFactoryOverrideInterface. It could use review.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.