* We should create a configuration entity same as Views does.
* The configuration entity should be separate from the Rules expression classes.

Pull request: https://github.com/fago/rules/pull/104

Comments

fago’s picture

As discussed let's create two config entities in d8:
CMI: rules.reaction.NAME , entity "rules_reaction"
CMI: rules.component.NAME , entity "rules_component"

klausi’s picture

Status: Active » Needs review

Here is an example YAML export of the component config entity I'm currently working on:

uuid: 336cb8d1-d5b6-43d0-a426-38be296237f4
langcode: en
status: true
dependencies: {  }
id: test_rule
label: null
module: rules
description: ''
tag: ''
core: 8.x
expression_id: rules_rule
configuration:
  id: test_rule
  expression_id: rules_rule
  configuration:
    id: rules_rule
    conditions:
      id: rules_and
      conditions:
        -
          id: rules_condition
          condition_id: rules_test_true
          negate: false
    actions:
      id: rules_action_set
      actions:
        -
          id: rules_action
          action_id: rules_test_log

This currently saved under "rules.rule.test_rule", I will rename it to "rules.component.test_rule" next and also rename the config entity ID to "rules_component".

klausi’s picture

Issue summary: View changes
klausi’s picture

Status: Needs review » Fixed

And committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.