Problem/Motivation

After downloading the latest dev there is a syntax error.

PHP Parse error: syntax error, unexpected 're' (T_STRING) in qa_checklist/qa_checklist.module on line 351

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 3__themes_em__bash_.png185.42 KBjoelpittet
#1 2318065-1.patch515 bytesjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet’s picture

Status: Active » Needs review
FileSize
515 bytes

Minor patch, unescaped string.

TravisCarden’s picture

Status: Needs review » Fixed

Sure enough! Thanks, @joelpittet. Your patch has been committed.

joelpittet’s picture

FileSize
185.42 KB

@TravisCarden thanks for the quick fix! Just a note I saw that you have lots of whitespace left in your files.

Depending on your editor of choice there is likely a nice option to trim trailing whitespace on save to prevent from something to worry about.

If you use sublime there are some awesome drupal configs to snag over here: https://www.drupal.org/node/1346890

TravisCarden’s picture

Thanks, @joelpittet. I use PhpStorm similarly configured. I didn't write this code, though. I haven't actually been an active contributor to this project in a long time. I just jumped in here for this because I saw you fixed a fatal error and I wanted to encourage your contribution. Feel free to submit patches for coding standards violations. For posterity: Coding standards handbook page and Coder Sniffer module. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.