Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
After downloading the latest dev there is a syntax error.
PHP Parse error: syntax error, unexpected 're' (T_STRING) in qa_checklist/qa_checklist.module on line 351
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#4 | 3__themes_em__bash_.png | 185.42 KB | joelpittet |
#1 | 2318065-1.patch | 515 bytes | joelpittet |
Comments
Comment #1
joelpittetMinor patch, unescaped string.
Comment #2
TravisCarden CreditAttribution: TravisCarden commentedSure enough! Thanks, @joelpittet. Your patch has been committed.
Comment #4
joelpittet@TravisCarden thanks for the quick fix! Just a note I saw that you have lots of whitespace left in your files.
Depending on your editor of choice there is likely a nice option to trim trailing whitespace on save to prevent from something to worry about.
If you use sublime there are some awesome drupal configs to snag over here: https://www.drupal.org/node/1346890
Comment #5
TravisCarden CreditAttribution: TravisCarden commentedThanks, @joelpittet. I use PhpStorm similarly configured. I didn't write this code, though. I haven't actually been an active contributor to this project in a long time. I just jumped in here for this because I saw you fixed a fatal error and I wanted to encourage your contribution. Feel free to submit patches for coding standards violations. For posterity: Coding standards handbook page and Coder Sniffer module. :)