Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paolomainardi’s picture

paolomainardi’s picture

Sorry there was a typo, this is the correct one.

paolomainardi’s picture

Sorry, a typo again :( i can't delete the previous ones.

kaare’s picture

Status: Needs review » Reviewed & tested by the community

Clean, decoupled code which works as promised. I've just migrated a cck-6.x-3.x multigroup field to this and had no trouble with it. It sure didn't work without this patch.

Kevin Hankens’s picture

Sweet! Thanks for the effort. I just realized that email notifications got turned off, so I'm just trying to catch up. I'll see about getting this into a new version soon.

paolomainardi’s picture

This patch fixes empty values.

brentrobbins’s picture

OMG, thank you paolomainardi. This is exactly what I needed and the tablefield_migrate-support-2317245-6.patch patch worked great (and by the way I am using ver 7.x-2.4). Thanks again!

paolomainardi’s picture

@kevinhankens can be merged ?

vitalie’s picture

Many thanks @paolomainardi. I can commit this, but I wonder if either:

* this can be put into a separate sub-module, e.g. tablefield_migrate

or

* the two new inc files moved to a includes/migrate folder.

Even it's a few lines of code, I think I prefer first option, since this is needed only a very short time in the life of a website, so a separate sub-module could be disabled/uninstalled when its job done.

paolomainardi’s picture

@vitalie i suggest to keep the structure as in the patch, if you see other modules it is accepted as a standard structure, create a separate module just for a class it is too much IMHO.

vitalie’s picture

ok, but I am still reluctant to dedicate tablefield.inc name for a file that only hosts a migrate class, that is only used at the beginning of the lifetime of a setup (most probably).

paolomainardi’s picture

@vitalie that is the way to be autoloaded by migrate module.

vitalie’s picture

Status: Reviewed & tested by the community » Needs work

@paolomainardi it's definitely not the only way. I've written migrate classes and successfully located them anywhere I really liked, actually.

paolomainardi’s picture

@vitalie yes there other ways too, but the one i propose is the mainly used and it is the standard way to do that :)

vaccinemedia’s picture

@paolomainardi I've applied the patch :) I'm using a yaml file as the source. Can you tell me how the value should look and give an example field mapping please?

lolandese’s picture

Version: 7.x-2.2 » 7.x-3.x-dev
noel.delacruz’s picture

I know this patch is for Drupal 7, is there a patch that supports the migration for the Drupal 8 version?