[D7] Audio Streaming Player

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2316863

Project 2: https://www.drupal.org/node/2273887

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxalarez2316801git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Duplicate of #2273887: [D7] countryicons_bw.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2316863

Project 2: https://www.drupal.org/node/2273887

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

No issues found in automated review PAReview.sh

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Unsure: Does not cause module duplication and fragmentation. How does this differ from modules like jPlayer

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template.

(*) Broken link to download library.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

URL Field accepts any input, does not validate URL. I attempted to test for XSS by inserting

<script>alert('XSS');</script>

into the URL, it was accepted, but did not display a javascript alert box when the block was loaded.

1. (*) Major finding
2. Minor finding
3. (+) Release blocker

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I could not get the stream to play, although the module loaded the block onto my test page without issue. I could not locate library from the link provided on the project page, I attempted to use the link from the site's main page: http://www.jplayer.org/2.6.0/jQuery.jPlayer.2.6.0.source.zip I'm wondering if this caused an incompatability.

Upon enabling the module I was met with the following errors.

Notice: Undefined variable: blocks in audio_streaming_player_block_info() (line 277 of /var/www/test-drupal/sites/all/modules/audio_streaming_player/audio_streaming_player.module).
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 389 of /var/www/test-drupal/modules/block/block.module).
Notice: Undefined variable: blocks in audio_streaming_player_block_info() (line 277 of /var/www/test-drupal/sites/all/modules/audio_streaming_player/audio_streaming_player.module).
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 389 of /var/www/test-drupal/modules/block/block.module).

each page while the module was active returned

Notice: Undefined index: data in drupal_process_attached() (line 4501 of /var/www/test-drupal/includes/common.inc).

not sure if this is again caused by me having a different version of the library. I'd be happy to test again if I can get the correct version of the library.

Getting following warnings while trying to enable this module through drush:

[root@bangvmplccpc01 modules]# git clone --branch 7.x-1.x http://git.drupal.org/sandbox/alarez/2316801.git audio_streaming_player
Initialized empty Git repository in /var/www/html/audio/sites/all/modules/audio_streaming_player/.git/
remote: Counting objects: 212, done.
remote: Compressing objects: 100% (204/204), done.
remote: Total 212 (delta 93), reused 0 (delta 0)
Receiving objects: 100% (212/212), 101.00 KiB | 39 KiB/s, done.
Resolving deltas: 100% (93/93), done.
[root@bangvmplccpc01 modules]# drush en audio_streaming_player
The following projects have unmet dependencies:                                                                                                              [ok]
audio_streaming_player requires libraries
Would you like to download them? (y/n): y
Project libraries (7.x-2.2) downloaded to sites/all/modules/libraries.                                                                                       [success]
The following extensions will be enabled: audio_streaming_player, libraries
Do you really want to continue? (y/n): y
Invalid argument supplied for foreach() block.module:389                                                                                                     [warning]
Invalid argument supplied for foreach() block.module:389                                                                                                     [warning]
audio_streaming_player was enabled successfully.                                                                                                             [ok]
audio_streaming_player defines the following permissions: administer audiostreamingplayer
libraries was enabled successfully.      

[ok]

Also, when trying to add a new player, images are not coming.

I'm seeing the same issue as @gaurav.pahuja, it appears your module breaks when running on a site that is in a sub-directory, doesn't seem to be obeying the baseurl settings.

All the issues looks fixed but fails when it try to get the song info. Also the browser console return this error
/sites/all/modules/contrib/audio_streaming_player/NowPlaying/as_getnowplaying.php 404 (Not Found)

@alarez I review the last commit and it works fine so I going to move this to "Reviewed & testes" unless someone has an objection

Duplication

This sounds like a feature that should live in the existing jPlayer project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the jPlayer issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process. If that fails for whatever reason please get back to us and set this back to "needs review".

If you feel that this should not be adding to an existing project, please describe the differences especially why a site admin would want to choose one over the other.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2273887

Project 2: https://www.drupal.org/node/2316863

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.