Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Normally, I would not alter an outside library. However, seeing as how the version of jcarousel is so outdated, I feel like this modules jcarousel js is almost at the point of being its own thing.
The javascript exception that is thrown, warning of an infinite loop, is pointless. The error it is trying to prevent does not happen in any modern browsers. However, the exception it throws does break js in all modern browsers. I suggest we just remove it. In my case, it is breaking my panels pages admin panel, and for no reason.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | jcarousel-remove_infinite_loop_exception-2315847-3.patch | 580 bytes | mrmikedewolf |
Comments
Comment #1
mrmikedewolf CreditAttribution: mrmikedewolf commentedDon't use this actually. I'm re-working it.
Comment #2
mrmikedewolf CreditAttribution: mrmikedewolf commentedComment #3
mrmikedewolf CreditAttribution: mrmikedewolf commentedHere is a better one. Instead of throwing the exception and cancelling the show, we'll set the width to a fallback. Keep in mind, I am not patching the minified js. This makes makes future patches fail because it is all one line. You will have to minify the js yourself. I'm not sure of any ways around this.
Comment #4
mrmikedewolf CreditAttribution: mrmikedewolf commentedIf any one knows of a more elegant workaround to the minification issue, I would love to hear it. There's always something to learn.
Until then here is an option to minify once applying the patch.
jscompress.com/
Comment #5
markpavlitski CreditAttribution: markpavlitski commentedjcarousel.js (and jcarousel.min.js) are patched in the latest stable release to fix other outstanding bugs, so I'm open to it for this issue too, once it's RTBC.