config_translation.admin.css does not include RTL-specific css. Right now, the source column is at left, and the destination column is at right, against the right-to-left flow in an RTL page.

Before patch:


After patch:

CommentFileSizeAuthor
#8 mobile-patch-test.png50.9 KBseiplax
#6 patch-test-before.png54.95 KBseiplax
#6 patch-test-after.png52.76 KBseiplax
#4 config-admin-rtl-mobile.png22.41 KBherom
config-trans-admin-rtl.patch973 bytesherom
config-trans-rtl-after.png16.37 KBherom
config-trans-rtl-before.png20.67 KBherom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, config-trans-admin-rtl.patch, failed testing.

Status: Needs work » Needs review

herom queued config-trans-admin-rtl.patch for re-testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Looks great. Is the responsive version correct as well? When you size the window less wide? Is the source above the translation still?

herom’s picture

herom CreditAttribution: herom commented
FileSize
config-admin-rtl-mobile.png22.41 KB

YES, it is!

seiplax’s picture

seiplax CreditAttribution: seiplax commented
Assigned: Unassigned » seiplax
Issue tags: +FUDK
seiplax’s picture

seiplax CreditAttribution: seiplax commented
Assigned: seiplax » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
patch-test-after.png52.76 KB
patch-test-before.png54.95 KB

Tested on 8.0.x

Verified by enabling Configuration translations module that ships with D8 Core. The direct path with Arabic installed is admin/structure/types/manage/article/translate/ar/edit

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-config

Yay. I was concerned the responsive version would not work, but yay :)

seiplax’s picture

seiplax CreditAttribution: seiplax commented
FileSize
mobile-patch-test.png50.9 KB

yes, also confirming that mobile works.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Good catch, and awesome mobile testing, too! :D

Committed and pushed to 8.x. Thanks!

  • webchick committed 0025ee4 on 8.0.x 
    Issue #2315459 by herom, seiplax: Fixed RTL for config translation form.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.