[D7] Community Media Starter

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi avguy,

Manual review of the 7.x-1.x branch:

Coder: No coding style issues.

I think some more details in the README would be helpful, specially about dependencies. Refer https://www.drupal.org/node/2181737

I'm moving this to RTBC since there is very little point to anyone else reviewing the code. As already stated, this is currently just a modified Feature export. I didn't realize that promoting a project had become such a hassle. I can see why so much Drupal code is ending up on GitHub.

I should have just created this project myself and given @avguy access, but we are trying to get more people within community media who use these modules and distributions involved in maintaining the project.

Once promoted, this project will be added to .make files of https://www.drupal.org/project/cm_starterkit_easy, https://www.drupal.org/project/cm_starterkit_moderate, and https://www.drupal.org/project/cm_starterkit_difficult. The current calendar export is just the first of many that will eventually get added to this project.

@avguy has volunteered to manage the project so I asked him to create it, but the Feature exports and other code will be created by a handful of different developers and site admins.

The code to enable a Feature within an install profile will be added to each install profile's hook_install, but we can't do that until the project has an actual release.

Adding text to a README for a Feature that is enabled for sites when Drupal is installed makes very little sense. The documentation for the distributions this project will become part of what is already available at https://www.drupal.org/documentation/build/community-media. The install profile includes a menu link to the documentation. @avguy has also contributed to that documentation.

@avguy is already a co-maintainer on several projects and has been committing directly to https://www.drupal.org/project/cm_airing as well as submitting patches and polling releases for other project.

While I understand the original motivation for these project reviews, in cases like this it seems like it only serves to discourage a person who's been using Drupal for > 6 years who has already been engaged to get more involved from actually being able to do that.

I cannot wrap my head around what someone who's already has access to make commits to git as a co-maintainer would do with the permission to create or promote projects that they couldn't already do.

Please promote this project to the shortname cm_starters and give @avguy permission to create full projects in the future.

Thanks.

This is just a Features export, so there is no code we can review. The module file and all other files should be in the root of the repository, the subdirectories are not needed.

So we can't give the git vetted user role away on this Features export - are there any other contributions you made where you developed code on your own? Could you list them in the issue summary? Examples: contributed patches, commits to other projects etc.

Otherwise we can also continue with manually promoting this project for you, but I assume that is not what you want? Tagging accordingly as single project promotion for now.

The reason for the directories was described in this issue and the project page, but since Features are required for most distributions and this groups/process refuses to approve them it makes the decision to the whitelist these Feature export modules hosted on GitHub much easier to justify.

#2316955: Please Whitelist cm_starters project

I'm re-opening this issue, as it is already clearly described the reasons for this project and why @avguy should become the maintainer instead of somebody like @kreynen or myself who already have git permissions.

Please re-consider promoting this project, as it makes development of modules that are part of the Community Media Starterkits more difficult without it. For example, we are not able to include t() tags for localization if the module is hosted on GitHub, and we can't include these features in a starterkit profile package.

@avguy and @kreynen has already described the purpose of this module, as a collection of feature exports as part of installing Community Media Starterkit Easy, to make it easier for users of this starterkit to add particular features to their new site.

Rather than @kreynen (maintainer of many modules part of the CMDrupal project and co-maintainer of several others) or myself (maintainer of cm_theme and contributor to several other CMDrupal modules), encourage a long-time user and contributor like @avguy to maintain this developer-wise simple project.

I could not find the reason for the subdirectories, please add that to the project page or remove the unnecessary subdirectories.

The starters sub-directory is for the sub-modules. In that directory resides the sub-modules/features. In the Drupal repository there is currently only one sub-module. But more can be found at https://github.com/cmdrop/cm_starters, where development occurs until this project has been approved.

Putting modules in a sub-directory of the project is common procedure and is used by many other modules, such as Views: http://cgit.drupalcode.org/views/tree/modules. It better explains what it is, sub-modules, rather than simply sub-directories of one module.

In the case of this module, the sub-directory is called starters, because that's what it is: different starter features for the Community Media Starterkit Easy.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.