Another ye-olde-mega-patch, for misc/*.js files.

Don't worry, I skipped farbtastic and jQuery.

CommentFileSizeAuthor
#7 javasscript_comment_standarads_2.patch14.98 KBredndahead
#5 javascript_comment_standards_1.patch14.98 KBredndahead
#2 javascript_commentstandards.patch14.02 KBbirdmanx35
javascript_commentstandards.patch14.02 KBbirdmanx35
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

+ default: // all other keys.
Should probably be "All other keys." Otherwise this is RTBC.

birdmanx35’s picture

birdmanx35 CreditAttribution: birdmanx35 commented
Status: Needs work » Needs review
FileSize
javascript_commentstandards.patch14.02 KB

Here goes.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Good good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs work

No longer applies.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Status: Needs work » Needs review
FileSize
javascript_comment_standards_1.patch14.98 KB

Rerolled to head.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

Same problem as catch pointed to in #1.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
FileSize
javasscript_comment_standarads_2.patch14.98 KB

Got the second one but didn't see the first one.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Status: Needs work » Needs review

hmm let's review

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs review » Reviewed & tested by the community

Patch look good + comment #1 corrected.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice little improvement. Thanks guys! :)

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.