$form_state is now a classed object

Okay, there's more.

[Thu Jul 31 16:04:39.381386 2014] [:error] [pid 16869] [client 127.0.0.1:53608] PHP Fatal error: Call to a member function get() on a non-object in /var/www/html/head/modules/devel/src/Form/SettingsForm.php on line 30

Here's a new attempt. I've simply added Request $request = NULL to buildform() in SettingsForm.php

And the interdiff.

And the devel_generate failure.

It's failing because of:

public function settingsForm(array $form, array &$form_state) {
  $form['num'] = array(
    '#type' => 'textfield',
    '#title' => t('How many users would you like to generate?'),
    '#default_value' => $this->getSetting('num'),
    '#size' => 10,
  );

Which throws:

Argument 2 passed to Drupal\devel_generate\Plugin\DevelGenerate\UserDevelGenerate::settingsForm() must be of the type array, object given, called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/devel/devel_generate/src/Form/DevelGenerateForm.php on line 77 and defined

Stupid typo.

Tests should fail later now.

More fixes.

Finished converting $form_state to a classed object.

Seems like the scope of this issue is fixed. https://qa.drupal.org/pifr/test/835538 is throwing errors with MENU_MAX_DEPTH that are related to https://www.drupal.org/node/2302069

Filed #2313803: MENU_MAX_DEPTH has been obsoleted