Problem/Motivation

Undefined location variable in the commerce billy pdf module.
Notice: Undefined variable: location in commerce_billy_pdf_commerce_order_view() (line 195 of /sites/all/modules/contrib/commerce_billy/modules/commerce_billy_pdf/commerce_billy_pdf.module).

This error is only in the case of canceled view mode.

Proposed resolution

invoice_location data is comming from the $settings variable.

CommentFileSizeAuthor
#6 commerce_billy-location_notice-2312343-6.patch1.87 KBlmeurs
#1 commerce_billy_pdf-location_notice-2312343-1.patch1.42 KBperi22
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

peri22’s picture

peri22 CreditAttribution: peri22 commented
FileSize
commerce_billy_pdf-location_notice-2312343-1.patch1.42 KB

This patch fixes the problem.

peri22’s picture

peri22 CreditAttribution: peri22 commented
Issue summary: View changes
lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Assigned: peri22 » Unassigned
Status: Active » Needs review
Issue tags: -location

This seems to be working - and I think the approach is allright. It is RTBC for me.

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Title: Undefined location variable » Undefined location variable for canceled orders
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented
Status: Needs review » Reviewed & tested by the community
lmeurs’s picture

lmeurs CreditAttribution: lmeurs commented
FileSize
commerce_billy-location_notice-2312343-6.patch1.87 KB

Thanks for the patch, attached a bit cleaner version.

timlie’s picture

timlie CreditAttribution: timlie commented

Patch in comment #6 works!

emerham’s picture

emerham CreditAttribution: emerham commented

any word on when this might be committed, I just changed the $ to an @ and the live version is working for me.

edit:
nm will apply patch, changing that character just prints "location"

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • klausi committed 4f40bce on 7.x-1.x authored by lmeurs 
    Issue #2312343 by peri22, lmeurs: Undefined location variable for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.