Hello there.

Description:

Recently I've ran into an issue, when tried to implement a template for the Fine Uploader.
By default it uses script tags with type set to "text/template" to store markup for the template. But since adaptivetheme_process_html_tag() cuts off the attribute, I never made it to work without a parsing error.
Fine Uploader allows the template to be set to a different element, but it's not a good way to go.

How to reproduce

  1. Add a script with type of "text/template".
  2. Look how the attribute has been torn off before render.

Comments

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Component: Theme Generator » Miscellaneous
Assigned: Unassigned » Jeff Burnz
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

I'm deprecating the original code, there was advice some years ago to do this sort of thing to fully support html5, however to be frank IMO it makes no difference what so ever.

This means things like Fine Uploader should work, since they can now properly set the type attribute.

  • Jeff Burnz committed 1949f6f on 7.x-3.x 
    Issue #2312157 by Jeff Burnz: adaptivetheme_process_html_tag() cuts off...
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Active » Fixed

Thank-you for the bug report. Hope this works for anyone having a similar issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.