The latest update uses hook_js_alter incorrectly causing the javascript clientsideValidation setting to not be passed to the page. This broke the validation on our site's forms.

CommentFileSizeAuthor
#1 clientside_validation-hook_js_alter_fix-2312043-1.patch695 bytesmrmikedewolf
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrmikedewolf’s picture

mrmikedewolf CreditAttribution: mrmikedewolf commented
FileSize
clientside_validation-hook_js_alter_fix-2312043-1.patch695 bytes

I've patched it to revert this change back to the last release. I don't believe it is best practices to do drupal_add_js in hook_js_alter.

mrmikedewolf’s picture

mrmikedewolf CreditAttribution: mrmikedewolf commented

In our case the clientsideValidation settings variable was not becoming instantiated on page load, but it was getting loaded by a subsequent ajax request. I'm not positive about this but I think by the time hook_js_alter fires it may be to late to add js to the queue.

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Active » Fixed

You are right, this sneaked past in as part of a different patch and I missed it. Thanks for the patch! Fixed in latest dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.