Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The background-position on RTL messages is not set properly. It is set using percents, and only works on a certain page width.
Here are some screenshots showing the issue (on a smaller screen).
normal (LTR):
RTL - before:
RTL - after:
Also there are issues with margins of messages container, they don't have proper margin-right margin-left in RTL languages. See #1 for screenshot.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | fix-rtl-messages-3-bartik.png | 15.29 KB | herom |
| #3 | fix-rtl-messages-3-seven.png | 8.89 KB | herom |
| #3 | fix-messages-rtl-css-2310321-3.patch | 1.14 KB | herom |
| #3 | interdiff-2310321-1-3.txt | 488 bytes | herom |
| #1 | interdiff_0_1.txt | 730 bytes | corbacho |
Comments
Comment #1
corbacho CreditAttribution: corbacho commentedGood work herom
Your patch fixes the issue of the icon. It's true that looked strange in narrow screens.
Reviewing your patch I found other CSS issues with RTL messages. I hope you don't mind I'm extending a bit the scope of this issue to cover it in the same patch.
These screenshots are taking in English language, modifying manually dir=rtl in the html element.
I tested in Bartik, Seven and Stark:
Where it says patch #1 should be #0
Where it says patch #3 it should be #1.
Sorry for the mess.
Comment #2
corbacho CreditAttribution: corbacho commented.
Comment #3
herom CreditAttribution: herom commentedNice catch with the margins, but we really shouldn't be changing the default LTR css in this issue. So, I removed the LTR changes in your patch.
Screenshots with the latest patch:
RTL messages in Seven:
RTL messages in Bartik:
Comment #4
corbacho CreditAttribution: corbacho commentedagree
Comment #5
alexpottCommitted 10e6812 and pushed to 8.x. Thanks!