Now that comments are render cached, the comments aren't updated when a patch is picked up by the bot.
This prevents finding the simpletest results, or using tools like https://github.com/Lullabot/drupal_qa_notifier to subscribe to the patch results.

On top of that, when the patches pass or fail, the comments are not updated.
The standard red/green of patches is very helpful, and it can be confusing if a patch looks stuck.

Can we possibly split this out somehow, or not cache comments that upload patches?

Comments

drumm’s picture

Assigned: Unassigned » drumm

  • drumm committed d49d12a on 7.x-3.x
    #2310011 Add last_tested timestamp and status for tests associated with...
drumm’s picture

Status: Active » Fixed
Issue tags: +needs drupal.org deployment
drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed.

Fabianx’s picture

FWIW, I had been under the impression that when test results are posted back either the comment or the node in question would be updated and therefore did add no special handling to this.

It is also possible to just update the comment modified timestamp instead. - JFYI

Thanks for the fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Wim Leers’s picture