Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now that comments are render cached, the comments aren't updated when a patch is picked up by the bot.
This prevents finding the simpletest results, or using tools like https://github.com/Lullabot/drupal_qa_notifier to subscribe to the patch results.
On top of that, when the patches pass or fail, the comments are not updated.
The standard red/green of patches is very helpful, and it can be confusing if a patch looks stuck.
Can we possibly split this out somehow, or not cache comments that upload patches?
Comments
Comment #1
drummComment #3
drummComment #4
drummNow deployed.
Comment #5
Fabianx CreditAttribution: Fabianx commentedFWIW, I had been under the impression that when test results are posted back either the comment or the node in question would be updated and therefore did add no special handling to this.
It is also possible to just update the comment modified timestamp instead. - JFYI
Thanks for the fix!
Comment #7
Wim LeersOpened another regression: #2334899: Comment render caching should happen per timezone.