Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It seems there are some issue because of megarow requests for refreshing the parent rows.
As they won't keep the destination, all the links from a refreshed row will have the destination the refresh megarow path.
There is a a Commerce Backoffice issue related : #2002008: Order operations destination changes after quick-edit save.
A solution is to pass the destination value to the refresh megarow request.
Comment | File | Size | Author |
---|---|---|---|
#7 | _patch-views_megarows-keep_destination-2309117-7.patch | 1.53 KB | lmeurs |
#6 | views_megarows-keep_destination-2309117-6.png | 22.78 KB | lmeurs |
#1 | keep_destination_on_refresh_megarows-2309117-1.patch | 1.88 KB | vasike |
Comments
Comment #1
vasikeand there is the patch that does it.
Comment #2
ArtusamakWhat behavior do we expect? If i'm opening a megarow i'm not expecting to be redirected at some point.
Comment #3
vasike@Artusamak: could you please check the related issue (Commerce Backoffice bug) : #2002008: Order operations destination changes after quick-edit save.
Comment #4
ArtusamakI did and it's not answering my question.
Comment #5
ArtusamakComment #6
lmeurs CreditAttribution: lmeurs commented@Artusamak: Take the operations menu in the screenshot for example. This menu does not only contain a Quick edit link that opens the megarow, but also links to other pages like the Edit and Delete links. The first link initially points at ie.:
admin/commerce/orders/13/edit?destination=admin/commerce/orders
but since the module does not preserve the initial destination parameter, after an AJAX submission the URL becomes:
admin/commerce/orders/13/edit?destination=views_megarow/refresh/commerce_backoffice_orders/admin_page
The problem is that after a quick edit all links in a megarow contain wrong destinations. When one clicks the Edit or Delete link, he will eventually get redirected to
views_megarow/refresh/commerce_backoffice_orders/admin_page
instead ofadmin/commerce/orders
.I adjusted vasike's patch to the latest dev, see attached.
Comment #7
lmeurs CreditAttribution: lmeurs commentedThe previous patch appended the destination parameter to the URL without respecting the optional
Drupal.settings.ViewsMegarow.args
arguments which were being appended on top of that. This is fixed in attached patch.Comment #8
ArtusamakOK, thanks for the patch it's committed.