Views date field exposed filter default value not being added in $form_state['input'] when initially views loads. I encounter this problem when i was creating a view with the date field filter.
I have a content type which have a release date field of date type and genre field of term reference type. I created a view with the Four filter

  1. Content:Published = Yes
  2. Content: Type = My content type
  3. Content: Genre field (exposed) with no default value set
  4. Content: Release date field (exposed) with no default value set

Release date field's granularity was set 'Year' in release date field configuration. I want to do alter the release date field value in exposed form in hook_form_alter().

Problem:
When initially views loads the value of release date field filter is not available in $form_state['input'] in hook_form_alter. while genre field filter value is available in $form_state['input']

CommentFileSizeAuthor
#7 interdiff-2309015-4-7.txt1.2 KBTemoor
#7 date-exposed-filter-form_state-empty-input-2309015-7.patch1.7 KBTemoor
#4 date_views-exposed_fiter_default_value_not_in_form_state-2309015-4.patch793 bytesmsankhala
#1 date_views-exposed_fiter_default_value_not_in_form_state-2309015-#1.patch985 bytesmsankhala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

msankhala’s picture

msankhala CreditAttribution: msankhala commented
Issue summary: View changes
FileSize
date_views-exposed_fiter_default_value_not_in_form_state-2309015-#1.patch985 bytes

The reason was that $form_state variable was not being passed by reference to date_parts_form function in date_views_filter_handler_simple handler. Attaching patch.

msankhala’s picture

msankhala CreditAttribution: msankhala commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: date_views-exposed_fiter_default_value_not_in_form_state-2309015-#1.patch, failed testing.

msankhala’s picture

msankhala CreditAttribution: msankhala commented
FileSize
date_views-exposed_fiter_default_value_not_in_form_state-2309015-4.patch793 bytes

Attaching new patch which follow patch creation standard.

msankhala’s picture

msankhala CreditAttribution: msankhala commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: date_views-exposed_fiter_default_value_not_in_form_state-2309015-4.patch, failed testing.

Temoor’s picture

Temoor CreditAttribution: Temoor commented
Version: 7.x-2.7 » 7.x-2.x-dev
Status: Needs work » Needs review
FileSize
date-exposed-filter-form_state-empty-input-2309015-7.patch1.7 KB
interdiff-2309015-4-7.txt1.2 KB

Reproduced in current dev version too.
Updated patch as long as previous one causes fatal error.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Fixed

#7 commited
Thanks!

  • podarok committed c2e081f on 7.x-2.x authored by Temoor 
    Issue #2309015 by msankhala, Temoor: Fixed views date field exposed...
m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Issue tags: +#ams2014contest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Issue tags: -

Just for the record, this commit introduced a new bug: #1437892: Undefined index notices in date_popup.module and default values disappear

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

@Temoor - You are setting the default to the current date in your patch, which is causing #2420323: Exposed date filter shouldn't automatically set a default date if none requested . I am trying to figure out another way of doing it but it would help to have your input since you are the patch author.

Ether’s picture

Ether CreditAttribution: Ether commented

Please rollback the patch as it introduces #2420323: Exposed date filter shouldn't automatically set a default date if none requested.