Fix undefined index error in biblio_admin_types_delete_form_submit() [#2308925]

Unable to delete a custom publication type. Generated error is:

Notice: Undefined variable: ftdids in biblio_admin_types_delete_form_submit() (line 1670 of /etc/drupal7/www.example.com/modules/biblio/includes/biblio.admin.inc).
•Warning: Invalid argument supplied for foreach() in DatabaseCondition->compile() (line 1853 of /usr/share/drupal7/includes/database/query.inc).
•PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: DELETE FROM {biblio_field_type_data} WHERE (ftdid IN ()) ; Array ( ) in biblio_admin_types_delete_form_submit() (line 1671 of /etc/drupal7/www.example.com/modules/biblio/includes/biblio.admin.inc).

MySQL version is 5.1.

Comment	File	Size	Author
#1	biblio-error_deleting_custom_publication_type-2308925-1.patch	1.88 KB	rupesh_jagtap
#1	7.x-1.x: PHP 7.2 & MySQL 5.5, D7.64 24 pass PHP 5.6 & MySQL 5.5, D7.64 24 pass PHP 7.1 & MySQL 5.5, D7.64 24 pass PHP 7.1 & PostgreSQL 9.1, D7.64 24 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rupesh_jagtap CreditAttribution: rupesh_jagtap commented 27 March 2015 at 10:51

Status:

Active

» Needs review

File	Size
biblio-error_deleting_custom_publication_type-2308925-1.patch	1.88 KB
7.x-1.x: PHP 7.2 & MySQL 5.5, D7.64 24 pass PHP 5.6 & MySQL 5.5, D7.64 24 pass PHP 7.1 & MySQL 5.5, D7.64 24 pass PHP 7.1 & PostgreSQL 9.1, D7.64 24 pass

Hi,

I have created a patch for mentioned bug. Please review it.

Comment #2

gmaxwelled CreditAttribution: gmaxwelled commented 16 April 2015 at 10:09

I can confirm that this patch fixes the issue.

Comment #3

joshuautley CreditAttribution: joshuautley commented 24 August 2015 at 23:07

Same here. Patch resolves the error.

Comment #4

joshuautley CreditAttribution: joshuautley commented 24 August 2015 at 23:07

Status:

Needs review

» Reviewed & tested by the community

Comment #5

rupesh_jagtap CreditAttribution: rupesh_jagtap as a volunteer and commented 21 July 2016 at 08:13

Status:

Reviewed & tested by the community

» Patch (to be ported)

@rjerome - Can you please merge the shared patch?

Comment #6

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 6 February 2019 at 17:55

Status:

Patch (to be ported)

» Reviewed & tested by the community

Restoring status.

Comment #7

8 February 2019 at 18:32

Liam Morland committed bf871ea on 7.x-1.x authored by rupesh_jagtap

Issue #2308925 by rupesh_jagtap, joshuautley, gmaxwelled, Liam Morland:...

Comment #8

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 8 February 2019 at 18:33

Title:	Error deleting custom publication type	» Fix undefined index error in biblio_admin_types_delete_form_submit()
Version:	7.x-1.0-rc7	» 7.x-1.x-dev
Status:	Reviewed & tested by the community	» Fixed