The 6.x-3.13 is introducing a bug when checking permission on older revisions.

        elseif (!$denied && $revision_node = node_load($content['nid'], $revision_id) && _node_revision_access($revision_node, 'view')) {
          // You have access to the node as well as that particular revision.
          $revision_access = TRUE;
        }

The middle clause with the value assignment needs to be wrapped in parenthese due to operator precendency.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nagba’s picture

Status: Active » Needs review
FileSize
709 bytes

this should fix the access check

gnindl’s picture

Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Works for me using revisioning module.

Indeed $revision_node is NULL and node_load() is never executed.

pwolanin’s picture

nagba’s picture

Sure it is. We can close this in favor of that one. Seem to have gotten more attention.

nagba’s picture

Status: Reviewed & tested by the community » Closed (duplicate)