Just tried installing 7.x.2.0 and turning on the modal module. This doesn't seem to work at all. It implements a hook hook_xmlsitemap_operation_link_alter() which is not invoked anywhere. The hook hook_xmlsitemap_link_alter() is documented, and looks like it should be the right one to use, but I think there is more to the problem than that: changing the name of the function in the modal does not seem to be enough on its own.

CommentFileSizeAuthor
#1 xmlsitemap--modal-2307573-1.patch412 bytesloopduplicate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

loopduplicate’s picture

Version: 7.x-2.0 » 7.x-2.x-dev
Status: Active » Needs review
FileSize
412 bytes

The latest commit in the dev branch is meant to solve this (well, according to the commit message, "Make xmlsitemap_modal kinda work."). I noticed that the new code doesn't use drupal_exit() but instead just uses exit(). This means that modules can't implement hook_exit().

Per the drupal_exit() docs: "There should rarely be a reason to call exit instead of drupal_exit();"

I'm attaching a patch for this.

Chris Matthews’s picture

The 4 year old patch to xmlsitemap_modal.module applied cleanly to the latest xmlsitemap 7.x-2.x-dev and if still applicable needs review.

renatog’s picture

Status: Needs review » Reviewed & tested by the community

#1 really works good

  • RenatoG committed a1f45b5 on 7.x-2.x authored by loopduplicate
    Issue #2307573 by loopduplicate, RenatoG, alfaguru, Chris2: Modal not...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.