Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mw4ll4c3’s picture

Warning / TODO: unlike the d7 equivalent, there is no fallback for values with the original name=>value. The new HOOK_UPDATE_N must be run, or output will be missing (and data will be lost on save.)

mw4ll4c3’s picture

Status: Active » Needs review
vijaycs85’s picture

+++ b/README.txt
@@ -15,8 +15,8 @@ Features
+* The current supported basic meta tags are ABSTRACT, CANONICAL, GEO.POSITION, ¶

@@ -78,8 +78,8 @@ Installing Nodewords (first time installation)
+    - Nodewords basic meta tags: for "abstract", "canonical", "description", ¶
+      "keywords", "logo", "original-source", "revisit-after", "rights", ¶

+++ b/nodewords_basic/nodewords_basic.install
@@ -69,3 +70,20 @@ function nodewords_basic_update_6115() {
+  ¶
...
+  } ¶
+  ¶

except few unwanted trailing spaces, it is +1 to RTBC.

mw4ll4c3’s picture

Ugh, whitespace...

vijaycs85’s picture

Thanks @mw4ll4c3.

+++ b/nodewords_basic/nodewords_basic.install
@@ -69,3 +70,20 @@ function nodewords_basic_update_6115() {
+  ¶
...
+  ¶

still few left :(

+++ b/nodewords_basic/nodewords_basic.info
@@ -1,5 +1,5 @@
\ No newline at end of file

new line at the end of the file please

mw4ll4c3’s picture

UGH. First patch on a new machine; thanks, Vijay (and sorry, D)

mw4ll4c3’s picture

mw4ll4c3’s picture

Here's a fresh (hopefully) clean patch. I also un-moved the _form/_prep functions' re-alphabetization, for the sake of a clean and clear diff

edit: I have no clue what's going on w/ that newline in the info file... I keep going in circles with my settings.

DamienMcKenna’s picture

Committed. Thanks mw4ll4c3!

DamienMcKenna’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.