Hi,

just installed the latest development version on Drupal 6.1 drupal. When trying to access the posts of a forum topic I get this error:
Fatal error: Unsupported operand types in .../includes/common.inc on line 1435

I think this is caused by new arguments to l(). With the help of the script from http://drupal.org/files/issues/replace.php_.txt I created the patch and the problem disappeared.

CommentFileSizeAuthor
advancedforuml.patch4.08 KBheirecka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pobster’s picture

Status: Needs review » Reviewed & tested by the community

Yeah seems to solve it for me.

Thanks,

Pobster

melodiesmaster’s picture

Yeah it works. Thanx a lot.

Michelle’s picture

Title: Fatal error: Unsupported operand types » Fix calls to l() in 6.x version
Assigned: Unassigned » Michelle

Hmm... I guess my reply on this yesterday must have gotten eaten when the site went down for maintainance.

Anyway, I forgot to change these again last time I did a mass copy of this section of code from the 5.x version. Will get these fixed in the next update.

Thanks,

Michelle

Michelle’s picture

I can't get your patch to work so I was doing the copy paste method and I noticed that you're changing some of the l() calls that are already in the D6 format like:

- $vars['comment_link'] = l($linktext, $linkpath, array('query' => $query, 'fragment' => $fragment));
+ $vars['comment_link'] = l($linktext, $linkpath, array('attributes' => array('query' => $query, 'fragment' => $fragment)));

What does putting them in an extra array do?

Michelle

Michelle’s picture

Status: Reviewed & tested by the community » Fixed

Changed the l()s that were formatted like 5.x. Didn't add in the extra level of array on the others because I don't understand the purpose and the links seem to be working fine as is.

Michelle

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.