Filter::process() method definition has changed so that it now has only two params and needs to return FilterProcessResult object.

CommentFileSizeAuthor
#7 pathologic-2304219-fix-broken-tests-7.patch3.54 KBja_ca
#5 fix-broken-tests-2304219-5.patch3.66 KBja_ca
#1 pathologic-2304219-filter_process_update-1.patch978 bytesblueminds
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blueminds’s picture

blueminds CreditAttribution: blueminds commented
Status: Active » Needs review
FileSize
pathologic-2304219-filter_process_update-1.patch978 bytes

Here is the patch.

blueminds’s picture

blueminds CreditAttribution: blueminds commented
Title: Small updates of 8.x branch » Filter::process() method definition has changed

Status: Needs review » Needs work

The last submitted patch, 1: pathologic-2304219-filter_process_update-1.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Reviewed & tested by the community

Forced a test so we get some feedback.

Tests are pretty broken right now, but if you compare the branch ouptut, this is a bit better than it was before ;)

We might be posting some patches to fix the tests, but this can still be committed.

ja_ca’s picture

ja_ca CreditAttribution: ja_ca commented
Status: Reviewed & tested by the community » Needs review
FileSize
fix-broken-tests-2304219-5.patch3.66 KB

This patch includes fixing the test and of course "pathologic-2304219-filter_process_update-1.patch" by @blueminds.
Basically had to update a few deprecated/removed functions.

Status: Needs review » Needs work

The last submitted patch, 5: fix-broken-tests-2304219-5.patch, failed testing.

ja_ca’s picture

ja_ca CreditAttribution: ja_ca commented
Status: Needs work » Needs review
FileSize
pathologic-2304219-fix-broken-tests-7.patch3.54 KB

Updated without including .DS_Store to the patch ;-)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented 
+++ b/src/Tests/PathologicTest.php
@@ -7,21 +7,19 @@
+ * @group Filter

Modules are apparently lowercased for the group.

If you look at the UI, you can confirm that the other tests are in filter, not Filter.

Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented

I'd like to thank you all for your work in this thread. I haven't been able to take a look at the patches yet due to general business, but I'll try to have a look this weekend.

Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented
Status: Needs review » Fixed

Okay, applied and pushed (with the correction by Berdir). Thanks, folks!

  • Garrett Albright committed 8ca9dcd on 8.x-1.x 
    Issue #2304219 by ja_ca, blueminds: Fixed Filter::process() method...
ja_ca’s picture

ja_ca CreditAttribution: ja_ca commented

No problem ;-) Thanks for pushing!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.