Problem/Motivation

The titleRow variable is unused/duplicate and also does not conform to the new standards of prefixing a JS variable with $ if it is a jQuery object.

Proposed resolution

Remove duplicate and refactor all usages to be $titleRow.
Patch below.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Comments

Elijah Lynn’s picture

Status: Active » Needs review
FileSize
1.9 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,210 pass(es). View

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

patch no longer applies.

anoopjohn’s picture

I see that the rule is violated not just in the titleRow variable but also in other variables in the file. Should we expand the scope of this fix to beyond the file like we do for coder fixes?

mayurjadhav’s picture

Assigned: Unassigned » mayurjadhav
harsha012’s picture

Version: 8.1.x-dev » 8.2.x-dev
Assigned: mayurjadhav » Unassigned
Status: Needs work » Needs review
harsha012’s picture

added patch for 8.2x version

mayurjadhav’s picture

@anoopjohn, Agreed with you and i think you have better understanding on this.

Uploading patch with updating some other variables, Please suggest/guide me if I miss other variables.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Manuel Garcia’s picture

Issue tags: -Needs reroll
nod_’s picture

Issue tags: +JavaScript clean-up

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.