I noticed Drupal 7 core releases are not getting included in the Project Dependency database tables. This is causing some dependencies to not be found. This does not seem to cause problems other than warning messages but I suppose could result in more serious problems in some cases. For Drupal 7.28 the code

$version = project_dependency_core_api_from_term($tag);
$info_file_pattern = $version >7 ? '.info.yml' : '.info';

$tag is 7.28. The result $version is 7.28. Since 7.28 is greater than 7 Project Dependency looks for .info.yml files. Looking at the function.

function project_dependency_core_api_from_term($core_api_term_name) {
  return preg_replace('/\.x.*$/', '', $core_api_term_name);
}

Contributed modules are something like 7.x-1.0 so this works. But the Drupal core releases do not have a 'x' in 7.28. I am curious about the history of this code but it seems like it is a bug.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

trobey’s picture

Status: Active » Needs review
FileSize
492 bytes

And the obvious patch.

trobey’s picture

Another function that fails on Drupal core releases. Updated patch.

  • trobey committed 1a9ac4c on 7.x-1.x
    Issue #2302233 by trobey: Fail to process Drupal 7core.
    
trobey’s picture

Status: Needs review » Fixed

Change committed to the development branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.