I'd like to test out this module using the simplytest.me drupal module testing service.

Because Views PDF requires the TCPDF and FPDI libraries, the module doing fully work with this service, because I'm unable to download and copy the library files to sites/all/libraries/.

From what I can tell, the integration of these libraries can be "automated" for use with simplytest.me.

see http://simplytest.me/qa

What about modules depending on external libraries?

If your module requires an external library (eg. a jQuery plugin), please read how to automatically resolve such dependencies by make-files. Simplytest.me will then execute the first drush make-file (.make or .make.example) it can find. Also please make sure that your make-files are still up-to-date and working.

CommentFileSizeAuthor
#8 2301067-8-add-make-file.patch1 KBkillua99
#5 2301067-5-add-make-file.patch948 byteskillua99
#6 2301067-6-add-make-file.patch956 byteskillua99
#7 diff-text-6-7.patch361 byteskillua99
#7 2301067-7-add-make-file.patch1.29 KBkillua99
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vegansupreme’s picture

vegansupreme CreditAttribution: vegansupreme commented

This seems easy enough. If this module was more friendly with simplytest.me, more people would try it and more people might use it.
This page was referenced by the simplytest QA page, and at the very bottom it says:

But, Is This A Good Idea?
Doing something like this would move control from profile builders to module developers. So, we need to ask if this control shift is a good idea? At this point I'm not clear on the answer.

That was from 2010, maybe by now this is settled?

It seems like this would also make it easier for any user to download and enable this module with drush.
Are there any issues with including a make-file?

Interested in submitting a patch?

bigdave’s picture

bigdave CreditAttribution: bigdave commented

I have tested several contrib modules with simplytest.me that required additional libraries and they worked just splendidly with the service.

I'm not associated with simplytest.me I just find it useful when browsing modules to be able to test them quickly without having to do much on my side.

Nor am I a developer by any sense of the word, so I wouldn't know where to start with a patch like like this.

killua99’s picture

killua99 CreditAttribution: killua99 commented
Version: 7.x-1.3 » 7.x-1.x-dev
Assigned: Unassigned » killua99

Sound fair to me. I'll try something.

Sound a solid solution better than use drush to download it.

killua99’s picture

killua99 CreditAttribution: killua99 commented
Priority: Normal » Critical
Status: Active » Needs work

This could be an easy Feature.

I'll try something.

killua99’s picture

killua99 CreditAttribution: killua99 commented
Priority: Critical » Normal
Status: Needs work » Needs review
FileSize
2301067-5-add-make-file.patch948 bytes

Need reviews.

killua99’s picture

killua99 CreditAttribution: killua99 commented
FileSize
2301067-6-add-make-file.patch956 bytes

Actually that patch need a revision. I'm looking how the module colorbox do it, and I'll replicate it.

killua99’s picture

killua99 CreditAttribution: killua99 commented
FileSize
2301067-7-add-make-file.patch1.29 KB
diff-text-6-7.patch361 bytes

Bah still, simplytest.me doesn't download the libraries, I'll add libraries 2.x as dependencie and I'll see.

killua99’s picture

killua99 CreditAttribution: killua99 commented
FileSize
2301067-8-add-make-file.patch1 KB

Ok last Change!

The url was so nasty than cause the wget broke. I try a "trick" and it work.

killua99’s picture

killua99 CreditAttribution: killua99 commented

WOah! it work!

The last patch is working on Simplytest.me :D

To test it you need to:

- go to: http://simplytest.me/
- search for views_pdf
- expand the advance options and fill the "patch file" with: http://www.drupal.org/files/issues/2301067-8-add-make-file.patch

Now when you navigate to simplytest.me/node#overlay=admin/reports/status you'll see in Green the libraries :)

And I could create a PDF file ;D

killua99’s picture

killua99 CreditAttribution: killua99 commented
Assigned: killua99 » Unassigned
vegansupreme’s picture

vegansupreme CreditAttribution: vegansupreme commented
Status: Needs review » Reviewed & tested by the community

Works on Simplytest.me. I haven't tried it on clean install with drush, but the OP is asking specifically about Simplytest.me. Think this is ready to commit?

killua99’s picture

killua99 CreditAttribution: killua99 commented

Well if @bigdave is around to test it and write a review could be nice. I'll wait a few days more.

killua99’s picture

killua99 CreditAttribution: killua99 commented

I'll commit this.

If you read this before I commit @vegansupreme you're free to commit it, I'll do it later ...

killua99’s picture

killua99 CreditAttribution: killua99 commented

I'll commit this.

If you read this before I commit @vegansupreme you're free to commit it, I'll do it later ...

  • vegansupreme committed 3451cdf on 7.x-1.x authored by killua99 
    Issue #2301067 by killua99: add a make-file to download TCPDF and FPDI...
vegansupreme’s picture

vegansupreme CreditAttribution: vegansupreme commented
Status: Reviewed & tested by the community » Fixed
killua99’s picture

killua99 CreditAttribution: killua99 commented

There ... thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vegansupreme’s picture

vegansupreme CreditAttribution: vegansupreme commented

I just tried to use simplytest with Views PDF and it didn't work this time. I tried with the Dev version which should include the make file, and I also tend the same procedure that worked before—using views_pdf 7.x-1.x and adding this patch.
The error I get when trying to create a PDF page is:
Fatal error: require_once(): Failed opening required 'sites/all/libraries/tcpdf/tcpdf.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/dfea5/www/sites/default/modules/views_pdf/views_pdf_template.php on line 16

killua99’s picture

killua99 CreditAttribution: killua99 commented

Might be something with simplytest? In the past it work, now, don't might be something with simplytest.

killua99’s picture

killua99 CreditAttribution: killua99 commented

Oh that was too fast for me.

URL problem, I add a short URL pointing to the right URL, it might change and they didn't work a redirect version (sourceforge)

Need to change the url for something like:

http://downloads.sourceforge.net/project/tcpdf/tcpdf_6_2_12.zip?r=http%3...

killua99’s picture

killua99 CreditAttribution: killua99 commented

Plus actually I'll to use the official Clone from github. In the past it wasnt there.

https://github.com/tecnickcom/TCPDF/archive/6.2.12.zip

I'll create a new issue for this.