Now that CKEditor includes a nice theme (since 2012) with a nice set of icons in low and high DPI, I thought it would be good to put together a crisp looking icon for Media.

CommentFileSizeAuthor
#5 hidpi_icon_for_ckeditor-2299859-5.patch4.44 KBtanc
#4 hidpi_icon_for_ckeditor-2299859-4.patch4.44 KBtanc
#1 hidpi_ckeditor.png13.99 KBtanc
#1 lowdpi_ckeditor.png8.43 KBtanc
#1 new_icon_ckeditor-2299859-1.patch4.44 KBtanc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc commented
FileSize
new_icon_ckeditor-2299859-1.patch4.44 KB
lowdpi_ckeditor.png8.43 KB
hidpi_ckeditor.png13.99 KB

I've uploaded a patch which adds a new icon in 1x and 2x dimensions to the media_wysiwyg sub module.

hidpi icon on toolbar

tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc commented
tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc commented
Related issues: +#2324313: Suggest new icon for ckeditor (media_wysiwyg module)
tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc commented
FileSize
hidpi_icon_for_ckeditor-2299859-4.patch4.44 KB

Re-roll to apply to latest 2.x-dev

tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc commented
Status: Active » Needs review
FileSize
hidpi_icon_for_ckeditor-2299859-5.patch4.44 KB

Updated patch to handle changes in newest 2.x-dev

dxx’s picture

dxx CreditAttribution: dxx commented

I have successfully applied this patch but after cleared all caches (drupal and browser), ckeditor persist to use the old link:

/sites/all/modules/contrib/media/modules/media_wysiwyg/wysiwyg_plugins/media_ckeditor/images/icon.gif?t=F0RD 404 (Not Found) (ckeditor.js?nodaqm:62)

ckeditor v4.4.7.3a35b3d

For now, my solution is to edit the file "media/modules/media_wysiwyg/wysiwyg_plugins/media.inc" at lines 15 and 16, replace with:

    'icon path' => drupal_get_path('module', 'media_wysiwyg') . '/wysiwyg_plugins/media_ckeditor/icons',
    'icon file' => 'media.png',
tanc’s picture

tanc
he/him
Primary language English
Location Italy
CreditAttribution: tanc as a volunteer commented

I think what's happening is that my patch is for the ckeditor module but ignores the wysiwyg module implementation. I'll have to take a look at including the icon for both.

dxx’s picture

dxx CreditAttribution: dxx commented

Oh okay ... Thank you for your work

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Title: HiDPI icon for CKEditor » HiDPI icon for WYSIWYG
Status: Needs review » Needs work
Related issues: +#2549407: Update the graphic for the media button

I see @tanc spit out an issue for media_ckeditor: #2549407: Update the graphic for the media button, so updating title.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs work » Closed (outdated)

Closing this issue as outdated. However, if you think this issue is still important, please let us know and we will gladly re-open it for review.
sincerely,
- the Drupal Media Team