Patch follows.

CommentFileSizeAuthor
#6 interdiff.txt2.4 KBslashrsm
#6 2298473_6.patch4.91 KBslashrsm
#3 2298473_3.patch5.34 KBslashrsm
#1 2298473.patch4.98 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Active » Needs review
FileSize
2298473.patch4.98 KB
marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Needs review » Needs work

Now this might just be me but the function is called memcache_log whereas the shutdown references memcache_log_warning

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs work » Needs review
FileSize
2298473_3.patch5.34 KB

Meh :)

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good!

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Reviewed & tested by the community » Needs review

If there is not a strange reason we need to keep the two is_callable() checks can we remove them please? Otherwise, looks good to go!

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
FileSize
2298473_6.patch4.91 KB
interdiff.txt2.4 KB

Fixed.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented 
+++ b/memcache.module
@@ -1,6 +1,22 @@
+ * Memcache cache backend must be configured in settings.php, and memcache.module
+ * is not strictly necessary to use memcache as a cache backend.

Not sure why this is being changed. If we're going to change it, might as well make it correct anyway. It's wrong now anyway so I will fix later.

  • damiankloip committed 16834c2 on 8.x-2.x authored by slashrsm 
    Issue #2298473 by slashrsm: Convert watchdog() calls to use logger...
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.