Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In order to ensure that future changes to code do not break existing functionality, there needs to be some basic test coverage for SMS Framework and key sub-modules. This issue is to keep track of efforts in the implementation of test coverage for these modules.
Proposed resolution
The plan is to identify key areas and functionality that need basic test coverage and add them to the list maintained below, then keep this issue updated by crossing out the ones that have been completed.
Remaining tasks
Provide test coverage for sms sending and gateway management.Provide test coverage for sms user integration and settings.Provide basic test coverage for sms blast.Provide basic test coverage for sms validation - #2374043: Provide basic test coverage for sms validation- Provide basic test coverage for sms actions - #2374047: Provide basic test coverage for sms actions
- Provide basic test coverage for sms sendtophone - #2374049: Provide basic test coverage for sms sendtophone
- #2365361: Tests for SMS Devel
User interface changes
None
API changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | develop_basic_test-2296447-3.patch | 16.37 KB | almaudoh |
| #2 | develop_basic_test-2296447-2.patch | 7.31 KB | almaudoh |
Comments
Comment #1
almaudoh CreditAttribution: almaudoh commentedComment #2
almaudoh CreditAttribution: almaudoh commentedPatch attached for basic test coverage for smsframework. Let's see if testbot picks it up.
Comment #3
almaudoh CreditAttribution: almaudoh commentedExtended patch in #2 with test coverage for sms_user integration and settings for user registration form.
Comment #5
almaudoh CreditAttribution: almaudoh commentedComment #6
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedEdit: moving request to another issue. There is test coverage for registration. I think I just need documentation
Could test coverage be added for sms registration in the sms_user module?
Comment #7
almaudoh CreditAttribution: almaudoh commentedComment #8
almaudoh CreditAttribution: almaudoh commentedTurning this into a meta issue. The remaining tasks will be done in child issues. Created:
Comment #9
almaudoh CreditAttribution: almaudoh commentedTests for sms_devel and sms_valid done.
Comment #10
almaudoh CreditAttribution: almaudoh commentedThe last 4 tests in this issue have been completed. Can close this issue out now.