In case it's helpful to anyone else, I've attached a patch that adds Salesforce Web-to-Lead Webform Data Integration functionality for non-Webform node content types that have the "Enable webform functionality" checkbox checked on the content type configuration screen.

CommentFileSizeAuthor
#1 sfweblead_webform_2295263.patch2.08 KBrklawson
webform_enabled_content_types.patch2.08 KBrklawson

Comments

rklawson’s picture

rklawson commented
StatusFileSize
new sfweblead_webform_2295263.patch2.08 KB
chriscalip’s picture

chriscalip commented
Version: 7.x-1.0-rc3 » 7.x-2.x-dev
chriscalip’s picture

chriscalip commented

Available at 7.x-2.x branch serves as compliance for webform 4.x

chriscalip’s picture

chriscalip commented
Status: Active » Fixed
rklawson’s picture

rklawson commented

I'm glad this got added in - thanks! Is there any way to get author attribution for it?

chriscalip’s picture

chriscalip commented

Thank you for reminding me. It was in the middle of the night.. ill put it on my to-do list. Cheers man.

rklawson’s picture

rklawson commented

No problem. I saw that the messages came through in the middle of the night - I really admire your dedication to your projects. Thanks again - cheers!

chriscalip’s picture

chriscalip commented

rklawson,

Hey thanks for helping out. That patch of yours was useful to me in trying to quickly getting back to the issue. I started out with every intention of using your patch; but just going through the issue made me realize that this contrib module was not taking full advantage of webform api https://www.drupal.org/node/1609324.

Through this two patches :
Node Salesform Webform Settings should not be in Node->Edit Page
https://www.drupal.org/node/2331821
Smaller Footprint, dont attach web2lead related things on node events.
https://www.drupal.org/node/2331855

I was able to fulfill the goal of "Functionality for other Webform-enabled Content Types" but without the extra baggage of tagging unnecessarily in node events. see previous post "Smaller Footprint .."

Nevertheless that patch provided above was used in the development; it just did not make the final cut. I still wanted to give your effort credit for it. Cheers you got an author credit on a patch. http://cgit.drupalcode.org/sfweb2lead_webform/commit/?id=95e7f80

Thanks,
Chris Calip

rklawson’s picture

rklawson commented

Hi Chris,

You're welcome. I'm glad that the patch was useful for development, and thanks for walking me through the process that you went through as you determined that you could take better advantage of the Webform API. Also, thank you giving me credit, and congrats on releasing version 2.0 of the module.

Cheers,
Rich Lawson

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.