Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.LanguageAddForm in language module still uses old D7-url() method.
It should be $this->url() or \Drupal::url().
Submitted the patch for the same.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-old-url-method-2293785-6.txt | 1.17 KB | joshi.rohit100 |
| #6 | old-url-method-2293785-6.patch | 1.25 KB | joshi.rohit100 |
| #4 | interdiff-2293785-0-4.txt | 1.01 KB | amitgoyal |
| #4 | old-url-method-2293785-4.patch | 1.1 KB | amitgoyal |
| old-url-method.patch | 1.1 KB | joshi.rohit100 | |
Comments
Comment #2
joshi.rohit100I investigated the testcase failure and found that, in testcases, block module is not enabled. So it dont find the specified route.
Once I added the 'block' module in the public static $modules and again tested, found that test run smoothly without any failure. So, I think, it is some test case related problem.
Comment #3
dawehnerIt is cool that this conversion allowed us to find bugs. I think you need to check whether the module exists and otherwise
not send something out in this case.
Comment #4
amitgoyal CreditAttribution: amitgoyal commentedI believe we have started using "!" over "@" for links. Please see if it makes sense to use the updated patch for the same.
Comment #6
joshi.rohit100Updated patch with check condition as per #3
Comment #8
mgiffordThis still a concern in D8? Unassigned issue too.
Comment #9
swentel CreditAttribution: swentel commentedCall is fine now, it's using $this->url()