Move our FeatureContext and *.features into panopoly_test so that child distributions can reuse them

This should work, but I think it will need the Drupal Extension fix in this issue: https://www.drupal.org/node/2093737. Otherwise you can't call functions like getRegion() from a subcontext.

I just confirmed that this fix is in version 1.0.2 and it does allow you to call getMainContext()->getRegion() from a subcontext.

Working on a patch - it's going well so far.

Two patches attached, one for the main panopoly and one for panopoly_test.

The only thing that is not yet working in a subcontext file is the fixStepArgument that allows you to use a previously-generated random value. So in this patch, it's still in FeatureContext.php.

Another useful thing to do would be set up FeatureContext.php so it can use parameters from the behat.yml file, if anyone adds them.

You have to install Behat fresh or run a composer update to get version 1.0.2 of the Drupal extension, which fixes the getRegion issue.

The problem with fixStepArgument is that you can't override it in a subcontext because it's defined in MinkContext, and the subcontexts do not inherit from MinkContext, only from BehatContext. There may be some OOP magic that can be done to get around this, otherwise this function has to stay in FeatureContext.php.

A similar problem will happen if you want to override any functions provided by the Drupal extension.

The thing you get with subcontexts created as *.behat.inc files is auto-loading. The FeatureContext.php can be completely bare-bones, but as long as you've got your behat.yml file set up correctly, all of the added step definitions will be loaded. So it's kind of mixing metaphors to have other step definitions for which you have to do something extra in FeatureContext.php. It does not allow a tester to drop in their own FeatureContext.php and get everything. And you have a situation where you've got mixed-up dependencies with things in panopoly_test vs. tests/behat.

So you'd have to go all one way or all another. This would mean either:

• figure out how to override MinkContext in a subcontext, perhaps with dependency injection? or
• give up on putting the step definitions in panopoly_test and have them all in PanopolyContext.php (or subcontexts included from there), which then has to be included in and extended by FeatureContext.

For the "included in" part, there may be something you can do with autoloading.

And, this may be another ticket, but: The .features pretty much all have dependencies on panopoly_test (for the content type), but that module will not necessarily be enabled when the tests are run. Should the scenarios enable the module before they start, then disable it at the end?

To fix the mixed-up dependencies, it should work to have all of the test code (config, features, step definitions) included in the panopoly_test module. The FeatureContext.php will do nothing except require and extend PanopolyContext.php.

If a child distribution wants to use Panopoly test code, it should either use Panopoly's FeatureContext straight up, and run the composer.json in the panopoly_test module, OR, put tests wherever and make sure their behat.yml includes all of the locations to look for features and step definitions, and their FeatureContext can find PanopolyContext and extend it.

Two patches attached, one for the main Panopoly and one for panopoly_test.

The first removes all test code and config from the main repo.

The second adds all of the test code and config to panopoly_test. It also moves assets needed for the tests (i.e. files to upload) to the module and uses generic names for them. And finally, it turns FeatureContext.php into a stub that just requires and extends PanopolyContext.php, which contains the steps that can't live in the *.behat.inc files.

Ugh, not sure how that got messed up in the patch. A new patch is attached which fixes the comment and also adds README.md to the module.

Previous patch to test did not remove extra step definitions.

And here's an updated patch for the main repo that fixes the Travis script.

Right now the environment is building OK, but the file-upload tests are failing. Probably requires a different files path setting in behat.travis.yml.

Thanks for the tip - new patch attached.

The main menu region was not defined in the YML. Now it's added. Also updated panopoly makefile to include the latest panopoly_test patch.

submenu_widget is a new test - it's not finished. Right now it only tests that you can add an existing page to the main menu. Eventually it will include a real test for the submenu. Should I back it out of this patch?

OK. New patches attached without the submenu test.

Incorrect filename for uploaded image in wysiwyg test - fixed in this patch.

Woohoo!

The patch to the Panopoly makefile pulls in the patch for panopoly_test - once panopoly_test is committed, that reference needs to be taken out and pointed to the correct Git hash. That should be it for this issue.