Allow hook_views_pre_view() to alter the view

I need to switch view displays to filter referable content for specific roles.

/**
 * Implements hook_views_pre_view().
 *
 * Allows altering a view at the very beginning of views processing, before anything is done.
 */
function MY_MODULE_views_pre_view(&$view, &$display_id, &$args) {
  if ($view->name == 'my_view' && $display_id == 'entityreference' && _MY_MODULE_user_is_editor()) {
    $view->set_display('entityreference_all');
  }
}

This hook is never explicitly called by entityreference, so it's only executed when the display is executed in getReferencableEntities(). This is too late to switch displays, because initializeView() already sets handler options.

I fixed this by running $view->pre_execute() right after setting the display in initializeView().

    $this->view->set_display($display_name);
    $this->view->pre_execute();

See also: https://api.drupal.org/api/views/includes!view.inc/function/view::pre_ex...