Upon expanding the save choices for a content edit, I have to scroll to make all choices visible and the scroll has to be done in a particular way.

Steps:
1. Create a content type which requires scrolling to enter all content.
2. Click Add content, and choose a that content type
3. Scroll down to the bottom
4. On the Save and publish button, click the down arrow.

Actual result: Options run off the screen
Expected result: Options are visible on screen. This might be done either by moving the button up or by providing for the extra scroll space so that step 3 provides enough padding at the bottom that there is room for the button to expand fully without requiring further scrolling.

See after clicking down arrow.png [note: yellow rectangle at bottom is a Windows artifact and not part of the bug; gray button in lower left is a simplytest.me artifact]

5. Move the mouse to the scroll bar to scroll down

Actual result: Button collapses and there is no place to scroll
Expected result (required): There is still a place to scroll to and I can scroll down.
Expected result (optional): The button doesn't collapse and I can scroll down.

Workaround: Use the Page Down key to scroll down.

See after rolling off.png

Files: 
CommentFileSizeAuthor
#7 interdiff-2292083-5-7.txt1.23 KBadci_contributor
#7 scroll_opening_dropbutton-2292083-7.patch1.17 KBadci_contributor
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,844 pass(es). View
#5 2292083_scroll_opening_dropbutton-5.patch1.15 KBtompagabor
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,665 pass(es). View
after rolling off.png120.1 KBCharles Belov
after clicking down arrow.png118.5 KBCharles Belov

Comments

nod_’s picture

Version: 8.0-alpha12 » 8.0.x-dev
Issue tags: +frontend, +JavaScript

This is a duplicate of another issue but I don't remember. Leaving open for now.

nod_’s picture

Component: node system » markup
nod_’s picture

tompagabor’s picture

Status: Active » Needs review
tompagabor’s picture

FileSize
1.15 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,665 pass(es). View
jhedstrom’s picture

Status: Needs review » Needs work
+++ b/core/misc/dropbutton/dropbutton.js
@@ -27,7 +27,26 @@
+    // dropbutton object
...
+    // save offset parent, if element is absolute positioned, we need a relative position for calculation
...
+    // open the dropbutton

The comments here should follow coding standards (capitalized, with a period at the end).

+++ b/core/misc/dropbutton/dropbutton.js
@@ -27,7 +27,26 @@
+  ¶

Trailing whitespace here.

adci_contributor’s picture

Status: Needs work » Needs review
FileSize
1.17 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,844 pass(es). View
1.23 KB

Updated in according to the corrections in #6

nod_’s picture

Status: Needs review » Needs work

Doesn't pass eslint.

Also I'd like to have feedback from the UX team to know if we should scroll down the page OR open dropbutton the other way (expand on top instead of current expand to bottom).

Personally I'd rather not mess with scrolling.

Charles Belov’s picture

As issue filer, I would prefer step 4 be fixed:

4. On the Save and publish button, click the down arrow.

Actual result: Options run off the screen
Expected result: Options are visible on screen.

I don't see any point in making me scroll after I have indicated intent to interact with the button. So, I'm with #8 expand to top.

tompagabor’s picture

There was a patch (https://www.drupal.org/node/2307533) which give us enough space at the bottom for dropdown button. I think it resolves the most common situations, eg.: the site uses the Seven theme for administration.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.