Overview:-
I needed to get all the H1, Page Title and meta tags of the existing site we were planning to migrate from HTML to Drupal 7. Getting these manually seemed to be a tedious task. What I did was to create this module which intakes CSV of existing URLs (which we got from raven's tool or any other tool) and got all the required information in a csv format.
This module will simply fetch the H1 on the page and meta tags(Title, Description,Keywords) from the head section of the page.
Features:-
It provides you Meta information in csv format so you can export this csv in your Drupal project.
Requirements:-
It requires you to download Simplehtmldom file from External url and copy this file in your module include folder.
Installation:-
- Copy the whole "GET_METATAGS" directory to your modules
directory - "sites/all/modules". - Please download the latest version of PHP Simple HTML DOM Parser library from http://sourceforge.net/projects/simplehtmldom/ to you include folder,for example sites/all/modules/get_metatags/include/simple_html_dom.php
- Enable the module.
Project page (sandbox link):
https://www.drupal.org/sandbox/prafullmathur/2285573
Git Clone:-
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/prafullmathur/2285573.git get_metatags
PAReview
http://pareview.sh/pareview/httpsgitdrupalorgsandboxprafullmathur2285573git
Manual reviews of other projects:
https://www.drupal.org/node/2301439#comment-8958993
https://www.drupal.org/node/2228407#comment-8956371
https://www.drupal.org/node/2299443#comment-8948967
Comment | File | Size | Author |
---|---|---|---|
csv_demo.png | 14.29 KB | prafullmathur |
Comments
Comment #1
gisleComment #2
adammitchell CreditAttribution: adammitchell commentedHi,
I hope this helps, when a few of these issues are fixed I will give it another review.
Thanks,
Adam
Comment #3
prafullmathur CreditAttribution: prafullmathur commentedComment #4
prafullmathur CreditAttribution: prafullmathur commentedComment #5
prafullmathur CreditAttribution: prafullmathur commented@gisle Thanks for review my code.
I have created version branch for my module and also edit page with project page tips.
Comment #6
prafullmathur CreditAttribution: prafullmathur commented@adammitchell Thanks for review my code.
Please take another look in project for any other concern.
Comment #7
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
prafullmathur CreditAttribution: prafullmathur commentedComment #9
prafullmathur CreditAttribution: prafullmathur commentedComment #10
gisleRemoving bonus tag. The three reviews you've done are not manual reviews.
In two of them, you've just duplicated the output of the automated review.
In last one (where you address the quality of the project page) you don't actually take he time to tell the applicant why it failed your review and how it can be improved. You've just copy-pasted boilerplate text from the review checklist. And the git details you request was at that time already present on the applicant's project page (under the "Version control" tab - I believe you might have have confused the project page with the issue summary.)
You need to produce reviews with more substance to earn the bonus tag.
Comment #11
David Witczak CreditAttribution: David Witczak commentedHello prafullmathur,
simplehtmldom module uses Libraries API and not their respective folder, You should do the same.
Comment #12
pingwin4eg@prafullmathur
This module seems more like a script which doesn't need Drupal at all. You definitely must use existing https://www.drupal.org/project/simplehtmldom API module. And maybe you should do something with results of parsing, set them as existing contents metatag fields or something (try your imagination).
Except implementing hook_menu() and hook_schema() there are no Drupal API used in this module.
Also there are some significant issues found.
Comment #13
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14
prafullmathur CreditAttribution: prafullmathur commentedHi,
As I already told you that this module is helpful only if user want to Convert HTML website to Drupal website. If we have client who have the same above requirement then it is very userful.
I am facing so many trouble that's why i build the module for community. It will save lots of time.
Comment #15
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxprafullmathur2285573git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #16
gisleIn #1 above (2 years ago!), I said:
It is still very sparse. It doesn't even explain the use case for your module. The library it relies on works well in the CLI, so why is this a Drupal module?
Coding style
In addition to a number of issues (some significant, some minor) found by PAReview, the follow requires it to remain set to "Needs work":
Project does not use the library module for 3rd party components
In #2 above (2 years ago!), adammitchell said:
This has not been fixed and it is still a valid objection. Please fix this before requesting another review.
We require projects that use third party components to register those by means of the libraries module, so that they can be shared between several projects. If you don't do this the user may end up including several, possibly conflicting versions of the third party component.
Fragmentation/Duplication
I don't see the point of this project, as long as simplehtmldom API is exists. As a minimum (if you cannot add this functionality as a patch to, or sub-module of simplehtmldom API), you must inform users of your module about possible module duplication and/or fragmentation. This advisory must appear on your project page.
Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. As a minimum, we require that developers of a new module that overlaps an existing to inform users about possible functional overlap. This should be made is section with the heading "Similar projects and how they are different" on the project's project page that:
Please take a look at the project page template and add the section "Similar projects and how they are different".
Comment #17
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.