If the highcharts library isn't loaded. The javascript which adds the global options, causes the JS to crash, including all JS scripts that follow, since the function Highcharts() is undefined.

CommentFileSizeAuthor
#1 easycharst-global_options_post_load-2288923.patch1.3 KBSneakyvv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sneakyvv’s picture

Sneakyvv CreditAttribution: Sneakyvv commented
Assigned: Sneakyvv » Unassigned
Status: Active » Needs review
FileSize
easycharst-global_options_post_load-2288923.patch1.3 KB

This patch alters the library load and adds a post-load callback to which the code for setting the options is moved.

jyve’s picture

jyve CreditAttribution: jyve commented

Thanks for the patch! It has just been committed to the dev version.

  • jyve committed 139a48d on 7.x-1.x 
    path in issue #2288923 applied
jyve’s picture

jyve CreditAttribution: jyve commented
Assigned: Unassigned » jyve
Status: Needs review » Closed (fixed)
Sneakyvv’s picture

Sneakyvv CreditAttribution: Sneakyvv commented

Hey jyve,

Glad my patch has been included, but no author reference? I hate to beg for credit, but... ;)

jyve’s picture

jyve CreditAttribution: jyve commented

My bad! I reapplied the patch with the right credits.