Problem/Motivation

See #2161801-49: Update hook_help for Config translation module - #50.

There is a pattern in hook_help for linking to other module hook help pages. But the other module might not be installed, so the link would break.
When it's not installed the link goes back to the original module help page... which is weird.

'!content-translation' => (\Drupal::moduleHandler()->moduleExists('content_translation')) ? \Drupal::url('help.page', array('name' => 'content_translation')) : '#'

Proposed resolution

Find all the places where help links like that, and add the phrase: if installed.
(Not enabled, since we dont enable modules anymore, we just install and uninstall them)

Remaining tasks

  • discuss proposed resolution, propose alternatives

User interface changes

Not really.

API changes

No.

Comments

jhodgdon’s picture

I was thinking we could be tricky and maybe not make an A link at all, but I don't see how that could work, given that we have to have a string to pass to t() that doesn't have variables in it or concatenation or whatever for the PO checker to pick up.

I think just making sure we're clearly stating "if installed" or "if enabled" is probably all we can do.

jhodgdon’s picture

Status: Active » Closed (cannot reproduce)

We've been reviewing all the help text and updating it this way for a while. Separate issue is not needed at this point.