Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Insert implements hook_field_widget_info_alter() to add Insert-specific settings to all fields in the system that can be inserted, regardless of whether the insert feature is enabled on those fields.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | insert-2285995-Insert_default_settings.patch | 1.78 KB | Snater |
| #4 | insert_features_overridden-2285995-4.patch | 1.46 KB | m.stenta |
Comments
Comment #1
m.stentaOops. False alarm. You can actually revert the Features... but it still would be nice to ONLY add the insert settings to a field if insert is enabled.
Comment #2
m.stentaClosing this... I'll open a new ticket if it makes sense to do what I described in my first comment. But maybe it's not necessary...
Comment #3
m.stentaActually, I was wrong (again)... you CANNOT revert these Features. So to reiterate (since I removed this from the original issue description):
"Unfortunately, if you have a field in a Features module that does not have insert enabled on it, that Feature always appears as overridden, even if you "revert" it manually. This is due to the hook_field_widget_info_alter() adding it to the field array.
It's possible to simply add these blank, disabled insert options to the Feature module code, and then it does not appear as "overridden". But ultimately, this isn't always possible (if you're using someone else's Feature, for instance, and they don't use Insert)."
Comment #4
m.stentaAttached is a patch which allows overridden Features to be reverted.
Basically, what it does is simply get rid of hook_field_widget_info_alter(), and instead saves field Insert settings to an entity type only when it is saved in the admin UI. Doing so causes any Feature with that field to appear overridden (because it will have the Insert settings included), BUT because it's no longer using hook_field_widget_info_alter(), it's possible to revert the overridden Feature.
It doesn't solve the ultimate goal of only saving the settings if Insert is enabled, but it's a step in that direction.
Comment #5
Snater CreditAttribution: Snater commentedBrowsing through old tickets while working on the module's D8 version. This is a reasonable change. I tweaked it a little bit an will merge it into the repo, unless there is any objection.
I assume preventing saving the settings at all when Insert is disabled, could be done by attaching a
#validatecallback to the form ininsert_form_field_ui_field_edit_form_alter. But I guess the intention would be to also remove (reset) all Insert settings when disabling Insert, which is probably not what I would expect from a user perspective when just unticking the Enable Insert checkbox.Comment #7
Snater CreditAttribution: Snater commented