Example: http://ci.aegirproject.org/view/Puppet/job/P_Aegir_Puppet_Module_functio...

Status is SUCCESS ... but ... the test run claims "Running tests failed"

Comments

helmo’s picture

Issue summary: View changes
Deleting /var/aegir/platforms/openatrium/themes/engines/phptemplate directory successful.                                                                                           [success]
Deleting /var/aegir/platforms/openatrium/themes/engines directory successful.                                                                                                       [success]
Deleting /var/aegir/platforms/openatrium/themes directory successful.                                                                                                               [success]
Deleting /var/aegir/platforms/openatrium directory successful.                                                                                                                      [success]
Running tests failed                                                                                                                                                                [error]
Connection to 127.0.0.1 closed.
==> default: Forcing shutdown of VM...
==> default: Destroying VM and associated drives...
==> default: Running cleanup tasks for 'puppet' provisioner...
jenkins@zeus:~/jobs/P_Aegir_Puppet_Module_functional_test_Aegir3-dev/workspace$ echo $?
0
  if (drush_get_error() != DRUSH_SUCCESS) {
    return drush_set_error(drush_get_error(), 'Running tests failed');
  }

drush_set_error always returns FALSE, which should be OK to get the exit code from drush to be non-zero.

Related: #1735230: Drush pm-download exit with 0 even when no release is found

John Pugh mentions the same issue in #13, https://drupal.org/node/1735230#comment-7570449

This works OK on several test systems I tried(both drush 6.x and 7,x), but apparently not on our wheezy vagrant image.

Adding a hard exit(1) seems to do the job ;)

helmo’s picture

Status: Active » Fixed

fixed a long time ago....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.